Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button size style #47074

Merged
merged 9 commits into from Jan 23, 2024
Merged

Fix button size style #47074

merged 9 commits into from Jan 23, 2024

Conversation

crazyair
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

#47053

📝 Changelog

Language Changelog
🇺🇸 English Button size style reduce weight
🇨🇳 Chinese Button size 样式降低权重

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 20, 2024

Visual Regression Report for PR #47074 Failed ❌

Target branch: master (a810c2f)
View Full Report


image name expected actual diff
empty-config-provider.compact.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff
empty-config-provider.compact.css-var.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff
empty-config-provider.dark.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff
empty-config-provider.dark.css-var.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff
empty-config-provider.default.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff
empty-config-provider.default.css-var.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff
transfer-basic.dark.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff
transfer-basic.dark.css-var.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff
transfer-basic.default.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff
transfer-basic.default.css-var.png master: a810c2ff54422a6da7db505dba5a0cdd43716a33 current: pr-47074 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Jan 20, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 20, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 331.17 KB (+2 B 🔺)
./dist/antd-with-locales.min.js 377.2 KB (-355 B 🔽)

Copy link

codesandbox-ci bot commented Jan 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ac9086b:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a810c2f) 100.00% compared to head (ac9086b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47074   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12553     12554    +1     
  Branches      3294      3294           
=========================================
+ Hits         12553     12554    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Jan 20, 2024

diff 差的有点多。

@crazyair
Copy link
Member Author

diff 差的有点多。

之前一直没跑成功,我看看,尽量没 diff

@crazyair
Copy link
Member Author

diff 没问题了吧?

@MadCcc
Copy link
Member

MadCcc commented Jan 23, 2024

看起来改制后的 Transfer 和 v4 是一致的

@MadCcc MadCcc merged commit ea02766 into master Jan 23, 2024
105 of 106 checks passed
@MadCcc MadCcc deleted the fix-button-size-style branch January 23, 2024 02:20
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

MadCcc pushed a commit that referenced this pull request Jan 29, 2024
* fix: Button size style

* fix: Button size style

* feat: default 补充默认样式

* feat: style

* feat: style

* feat: style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants