Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notification support duration #47141

Merged
merged 2 commits into from Jan 24, 2024
Merged

feat: notification support duration #47141

merged 2 commits into from Jan 24, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 24, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #47060

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Notification useNotification support duration config, which will also support with App config.
🇨🇳 Chinese Notification useNotification 支持 duration 配置,该更新同样适用于 App 组件的 notification 配置。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Visual Regression Build for PR #47141 Failed ❌

Potential causes:

  • upstream workflow status: failure upstream job link
  • download report artifact status: failure
  • report upload status: skipped

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 24, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 331.27 KB (-106 B 🔽)
./dist/antd-with-locales.min.js 377.18 KB (-43 B 🔽)

Copy link

codesandbox-ci bot commented Jan 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 944e17a:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b9ced5) 100.00% compared to head (944e17a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12558     12559    +1     
  Branches      3294      3295    +1     
=========================================
+ Hits         12558     12559    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 7664f39 into feature Jan 24, 2024
104 of 106 checks passed
@zombieJ zombieJ deleted the duration branch January 24, 2024 07:25
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants