Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Use description color instead of disabled in Empty #47268

Merged

Conversation

evgmol
Copy link
Contributor

@evgmol evgmol commented Jan 31, 2024

🤔 This is a ...

Component style update

💡 Background and solution

Imo, using the disabled color for description makes the text to be way too light: as a user I think it's not readable enough. And it does not comply with a11y guidelines.

📝 Changelog

The description text for empty states has become slightly darker

Language Changelog
🇺🇸 English The description text for empty states has become slightly darker
🇨🇳 Chinese 空状态的描述文本变得稍微暗一些

Signed-off-by: evgmol <146968816+evgmol@users.noreply.github.com>
Copy link

stackblitz bot commented Jan 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Visual Regression Report for PR #47268 Failed ❌

Target branch: master (057e81f)
View Full Report


image name expected actual diff
cascader-panel.compact.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff
cascader-panel.compact.css-var.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff
cascader-panel.dark.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff
cascader-panel.dark.css-var.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff
cascader-panel.default.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff
cascader-panel.default.css-var.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff
config-provider-locale.compact.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff
config-provider-locale.compact.css-var.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff
config-provider-locale.dark.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff
config-provider-locale.dark.css-var.png master: 057e81f11dad23f244d21d2eb04f709c8a5bf0fa current: pr-47268 diff

Check Full Report for details

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3a2ed69:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (057e81f) 100.00% compared to head (3a2ed69) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47268   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12563     12563           
  Branches      3296      3296           
=========================================
  Hits         12563     12563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 changed the title Use description color instead of disabled in Empty style: Use description color instead of disabled in Empty Mar 16, 2024
@afc163 afc163 merged commit 13ed05f into ant-design:master Mar 16, 2024
66 of 67 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
…#47268)

Signed-off-by: evgmol <146968816+evgmol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants