New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Use description color instead of disabled in Empty #47268
style: Use description color instead of disabled in Empty #47268
Conversation
Signed-off-by: evgmol <146968816+evgmol@users.noreply.github.com>
Run & review this pull request in StackBlitz Codeflow. |
Visual Regression Report for PR #47268 Failed ❌
Check Full Report for details |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3a2ed69:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47268 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 732 732
Lines 12563 12563
Branches 3296 3296
=========================================
Hits 12563 12563 ☔ View full report in Codecov by Sentry. |
…#47268) Signed-off-by: evgmol <146968816+evgmol@users.noreply.github.com>
🤔 This is a ...
Component style update
💡 Background and solution
Imo, using the disabled color for description makes the text to be way too light: as a user I think it's not readable enough. And it does not comply with a11y guidelines.
📝 Changelog
The description text for empty states has become slightly darker