Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): Virtual table style lead on none virtual table used as a nested table #47333

Merged
merged 6 commits into from Feb 6, 2024

Conversation

Enigama
Copy link
Contributor

@Enigama Enigama commented Feb 4, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #47317

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix style for Table that renders inside virtual by updating style for ${componentCls}-row add :not(tr)
🇨🇳 Chinese 通过更新 ${componentCls}-row 的样式来修复在虚拟内部渲染的表的样式,添加 :not(tr)

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 4, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Feb 4, 2024

👁 Visual Regression Report for PR #47333 Passed ✅

🎯 Target branch: master (c3c9cfd)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

codesandbox-ci bot commented Feb 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 924bb73:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd0104f) 100.00% compared to head (924bb73) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47333   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12590     12590           
  Branches      3295      3295           
=========================================
  Hits         12590     12590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Enigama
Copy link
Contributor Author

Enigama commented Feb 4, 2024

@afc163 who can approve this one? Thanks

@yoyo837 yoyo837 requested a review from zombieJ February 5, 2024 01:40
@yoyo837
Copy link
Contributor

yoyo837 commented Feb 5, 2024

Please add some test case for it.

@Enigama
Copy link
Contributor Author

Enigama commented Feb 5, 2024

@yoyo837 I've added a test for my fix

@afc163 afc163 merged commit 87882e1 into ant-design:master Feb 6, 2024
62 checks passed
Copy link
Contributor

github-actions bot commented Feb 6, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@MadCcc MadCcc mentioned this pull request Feb 10, 2024
20 tasks
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
…nested table (ant-design#47333)

* fix(style): Virtual table style lead on none virtual table render used as a nested table.

* fix(test): Update test for virtual table with fix nested table inside.

---------

Co-authored-by: ykryshtal <ykryshtal@magnite.com>
Co-authored-by: Eugene <Jeka1.1@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual Table expandedRowRender ChildTable render incorrectly
4 participants