Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: borderless tag should use defaultBg #47372

Merged
merged 1 commit into from Feb 7, 2024
Merged

fix: borderless tag should use defaultBg #47372

merged 1 commit into from Feb 7, 2024

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Feb 6, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #47370

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tag that should use defaultBg token with bordered={false}.
🇨🇳 Chinese 修复 Tag 无边框模式没有正确使用 defaultBg 组件 token 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 6, 2024

👁 Visual Regression Report for PR #47372 Failed ❌

🎯 Target branch: master (54b7c3e)
📖 View Full Report ↗︎

Image name Expected Actual Diff
tag-component-token.compact.png master: 54b7c3e09d1fe3b3fd30b3192f894723212f2a10 current: pr-47372 diff
tag-component-token.compact.css-var.png master: 54b7c3e09d1fe3b3fd30b3192f894723212f2a10 current: pr-47372 diff
tag-component-token.dark.png master: 54b7c3e09d1fe3b3fd30b3192f894723212f2a10 current: pr-47372 diff
tag-component-token.dark.css-var.png master: 54b7c3e09d1fe3b3fd30b3192f894723212f2a10 current: pr-47372 diff
tag-component-token.default.png master: 54b7c3e09d1fe3b3fd30b3192f894723212f2a10 current: pr-47372 diff
tag-component-token.default.css-var.png master: 54b7c3e09d1fe3b3fd30b3192f894723212f2a10 current: pr-47372 diff

Check Full Report for details

Copy link

codesandbox-ci bot commented Feb 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3cdd65c:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link
Contributor

github-actions bot commented Feb 6, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.42 KB (-4 B 🔽)
./dist/antd-with-locales.min.js 379.13 KB (-122 B 🔽)

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c9e5a6) 100.00% compared to head (3cdd65c) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47372   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12590     12590           
  Branches      3295      3295           
=========================================
  Hits         12590     12590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit a4c4c47 into master Feb 7, 2024
110 of 111 checks passed
@MadCcc MadCcc deleted the fix/tag-token branch February 7, 2024 02:20
Copy link
Contributor

github-actions bot commented Feb 7, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@MadCcc MadCcc mentioned this pull request Feb 10, 2024
20 tasks
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

当Tag设置Bordered=false时,defaultBg Token不生效
2 participants