Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dropdown should not display when items is empty array #47375

Merged
merged 2 commits into from Feb 7, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 6, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

close #47373

📝 Changelog

Language Changelog
🇺🇸 English Fix Dropdown should not display when items is empty array
🇨🇳 Chinese 修复 Dropdown menu.items 为空时依然显示的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

👁 Visual Regression Report for PR #47375 Passed ✅

🎯 Target branch: master (a4c4c47)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Preview is ready

@afc163 afc163 marked this pull request as ready for review February 6, 2024 09:40
Copy link
Contributor

github-actions bot commented Feb 6, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.46 KB (+72 B 🔺)
./dist/antd-with-locales.min.js 379.41 KB (+54 B 🔺)

Copy link

codesandbox-ci bot commented Feb 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b1cf6d:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4c4c47) 100.00% compared to head (6b1cf6d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47375   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12593     12593           
  Branches      3298      3298           
=========================================
  Hits         12593     12593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

li-jia-nan
li-jia-nan previously approved these changes Feb 6, 2024
@MadCcc
Copy link
Member

MadCcc commented Feb 7, 2024

还是会有阴影
image

@zombieJ
Copy link
Member

zombieJ commented Feb 7, 2024

印象里,windows 的菜单空的时候右击还会显示。但是有个 [空],来表示交互是有效的。(图找了一圈没找到。。。)

@afc163 afc163 merged commit 3d1c81d into master Feb 7, 2024
106 checks passed
@afc163 afc163 deleted the fix/dropdown-style branch February 7, 2024 12:22
Copy link
Contributor

github-actions bot commented Feb 7, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@MadCcc MadCcc mentioned this pull request Feb 10, 2024
20 tasks
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
…n#47375)

* fix: Dropdown should not display when items is empty array

* Apply suggestions from code review

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown style problem with emtpy items
4 participants