New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dropdown should not display when items is empty array #47375
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #47375 Passed ✅
🎊 Congrats! No visual-regression diff found. |
f0528a8
to
7150724
Compare
size-limit report 📦
|
7150724
to
aafd3ce
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6b1cf6d:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47375 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 734 734
Lines 12593 12593
Branches 3298 3298
=========================================
Hits 12593 12593 ☔ View full report in Codecov by Sentry. |
Signed-off-by: afc163 <afc163@gmail.com>
55cb1e7
to
6b1cf6d
Compare
印象里,windows 的菜单空的时候右击还会显示。但是有个 |
…n#47375) * fix: Dropdown should not display when items is empty array * Apply suggestions from code review Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com>
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
close #47373
📝 Changelog
menu.items
为空时依然显示的问题。☑️ Self-Check before Merge