Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rc-table from 7.39.0 to 7.40.0 #47382

Merged
merged 2 commits into from Feb 7, 2024
Merged

chore: bump rc-table from 7.39.0 to 7.40.0 #47382

merged 2 commits into from Feb 7, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Feb 7, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 1. Table support components.header.table for scrollable header component customize.
2. Fix Table sticky not show the scrollbar at first time.
3. Remove Table th will be replaced with td in header when title is empty.
🇨🇳 Chinese 1. Table 支持 components.header.table 以自定义滚动列时的标题组件。
2. 修复 Table sticky 下,初次渲染不会显示滚动条的问题。
3. 修复 Table 的 column.title 为空时列头没有使用 th 元素的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Visual Regression Report for PR #47382 Passed ✅

Target branch: feature (cfe7226)


Congrats! No visual-regression diff found

Copy link

socket-security bot commented Feb 7, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-table@7.40.0 Transitive: environment +14 6.22 MB afc163, benjycui, dxq613, ...6 more

View full report↗︎

Copy link
Contributor

github-actions bot commented Feb 7, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.27 KB (-28 B 🔽)
./dist/antd-with-locales.min.js 379.35 KB (+12 B 🔺)

Copy link

codesandbox-ci bot commented Feb 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 558e2cb:

Sandbox Source
antd reproduction template (forked) Configuration

@afc163
Copy link
Member

afc163 commented Feb 7, 2024

支持 header table 是啥意思?用户应该看不太懂。

@li-jia-nan
Copy link
Member Author

支持 header table 是啥意思?用户应该看不太懂。

@crazyair 来解释一下

@afc163
Copy link
Member

afc163 commented Feb 7, 2024

删除 td、th 标签的判断逻辑,统一使用 th 标签,不再区分场景

这个问题本身是啥?还是说对用户没有影响?

@li-jia-nan
Copy link
Member Author

这个问题本身是啥?还是说对用户没有影响?

@crazyair
Copy link
Member

crazyair commented Feb 7, 2024

支持 header table 是啥意思?用户应该看不太懂。

Table 设置 sticky 在 header 也有个 table 元素,对这个增加自定义

@afc163
Copy link
Member

afc163 commented Feb 7, 2024

Table 设置 sticky 在 header 也有个 table 元素,对这个增加自定义

这句话其实也看不太懂,不过这个属性确实比较抽象,我看看怎么写比较好。

@afc163
Copy link
Member

afc163 commented Feb 7, 2024

从用户视角尝试改了改。

原始背景:react-component/table#1066

  • 修复 Table 列头在某些情况下未使用 th 标签的问题。

Table 设置 sticky 在 header 也有个 table 元素,对这个增加自定义

  • Table 新增 components={{ header: { table: React.Component } }} 自定义组件,可用于替换 sticky 场景下的表头内的 table 元素。

@linxianxi
Copy link
Contributor

Table 设置 sticky 在 header 也有个 table 元素,对这个增加自定义

这句话其实也看不太懂。

他这个就是支持 components.header.table,没表达清楚

@zombieJ
Copy link
Member

zombieJ commented Feb 7, 2024

调整了一下描述,现在清楚了。

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfe7226) 100.00% compared to head (558e2cb) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47382   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12589     12589           
  Branches      3294      3294           
=========================================
  Hits         12589     12589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 55aae1e into feature Feb 7, 2024
111 checks passed
@li-jia-nan li-jia-nan deleted the table-bump branch February 7, 2024 03:44
Copy link
Contributor

github-actions bot commented Feb 7, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* chore: bump rc-table from 7.39.0 to 7.40.0

* test: update snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants