Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the color of Content should change in darkmode #47441

Merged
merged 1 commit into from Feb 18, 2024

Conversation

nova1751
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#47434

💡 Background and solution

The color of Content component of Layout stay the same when theme changes.Adding a color rule can solve this problem.

📝 Changelog

Language Changelog
🇺🇸 English Fix the font color of Content not change in darkmode
🇨🇳 Chinese 修复Content元素中的字体颜色在暗黑模式下不改变的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 14, 2024

👁 Visual Regression Report for PR #47441 Failed ❌

🎯 Target branch: master (e6b756a)
📖 View Full Report ↗︎

Image name Expected Actual Diff
layout-component-token.dark.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff
layout-component-token.dark.css-var.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff
layout-custom-trigger-debug.dark.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff
layout-custom-trigger-debug.dark.css-var.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff
layout-custom-trigger.dark.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff
layout-custom-trigger.dark.css-var.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff
layout-fixed.dark.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff
layout-fixed.dark.css-var.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff
layout-responsive.dark.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff
layout-responsive.dark.css-var.png master: e6b756ae9688d86e7b9ce1781ebca4033c643bf7 current: pr-47441 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Feb 14, 2024

Preview is ready

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6b756a) 100.00% compared to head (6c1700c) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47441   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12593     12593           
  Branches      3298      3298           
=========================================
  Hits         12593     12593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit d4c811c into ant-design:master Feb 18, 2024
63 of 64 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@nova1751 nova1751 deleted the style/darkmode branch February 19, 2024 10:59
@PeachScript PeachScript mentioned this pull request Feb 23, 2024
20 tasks
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants