Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Alert support aria-* in closable #47474

Merged
merged 3 commits into from Feb 19, 2024
Merged

Conversation

kiner-tang
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Alert support aria-* in closable
🇨🇳 Chinese 警告提示组件支持在 closable 中配置 aria-*

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 19, 2024

👁 Visual Regression Report for PR #47474 Failed ❌

🎯 Target branch: feature (ee27f0e)
📖 View Full Report ↗︎

Image name Expected Actual Diff
alert-closable.compact.png feature: ee27f0e285a33e020b985c07d4207b928561fb92 current: pr-47474 diff
alert-closable.compact.css-var.png feature: ee27f0e285a33e020b985c07d4207b928561fb92 current: pr-47474 diff
alert-closable.dark.png feature: ee27f0e285a33e020b985c07d4207b928561fb92 current: pr-47474 diff
alert-closable.dark.css-var.png feature: ee27f0e285a33e020b985c07d4207b928561fb92 current: pr-47474 diff
alert-closable.default.png feature: ee27f0e285a33e020b985c07d4207b928561fb92 current: pr-47474 diff
alert-closable.default.css-var.png feature: ee27f0e285a33e020b985c07d4207b928561fb92 current: pr-47474 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Feb 19, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.65 KB (+251 B 🔺)
./dist/antd-with-locales.min.js 379.62 KB (+403 B 🔺)

Copy link

codesandbox-ci bot commented Feb 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20cd731) 100.00% compared to head (dd0d914) 100.00%.
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47474   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12596     12615   +19     
  Branches      3300      3306    +6     
=========================================
+ Hits         12596     12615   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163

This comment was marked as resolved.

@afc163 afc163 merged commit 23cb9c5 into feature Feb 19, 2024
104 of 105 checks passed
@afc163 afc163 deleted the feature-aria-in-closable-alert branch February 19, 2024 05:40
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* feat: Alert support aria-* in closable

* feat: Alert support aria-* in closable

* feat: Alert support aria-* in closable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants