Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add destroyTooltipOnHide to Avatar.Group #47478

Merged
merged 1 commit into from Feb 20, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 19, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #47413

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Avatar.Group enabledestroyTooltipOnHide defaultly.
🇨🇳 Chinese Avatar.Group 默认开启 destroyTooltipOnHide 以避免多余的 dom 残留。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Visual Regression Build for PR #47478 Failed ❌

Potential causes:

  • upstream workflow status: failure upstream job link
  • download report artifact status: failure
  • report upload status: skipped

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Preview is ready

@li-jia-nan
Copy link
Member

要不透出去,让用户自己决定?默认值给个 true

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 333.61 KB (+63 B 🔺)
./dist/antd-with-locales.min.js 379.31 KB (-1 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9bb666) 100.00% compared to head (dc89072) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #47478    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          734       734            
  Lines        12788     12593   -195     
  Branches      3390      3298    -92     
==========================================
- Hits         12788     12593   -195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member Author

afc163 commented Feb 19, 2024

想不到什么场合需要改回 false。

@afc163 afc163 merged commit fc1fb17 into master Feb 20, 2024
113 of 114 checks passed
@afc163 afc163 deleted the fix/avatar-destroyPopupOnHide branch February 20, 2024 10:07
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@PeachScript PeachScript mentioned this pull request Feb 23, 2024
20 tasks
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar Group Popover Destroy Popup on Hide
2 participants