Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: css var prefix follow prefixCls by default #47481

Merged
merged 2 commits into from Feb 20, 2024
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Feb 19, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Currently css var prefix is separated with prefixCls on ConfigProvider. This PR make it follow prefixCls by default.

📝 Changelog

Language Changelog
🇺🇸 English prefix of css var should follow prefixCls of ConfigProvider by default.
🇨🇳 Chinese CSS 变量的前缀默认跟随 ConfigProvider 的 prefixCls 属性。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Visual Regression Build for PR #47481 Failed ❌

Potential causes:

  • upstream workflow status: failure upstream job link
  • download report artifact status: failure
  • report upload status: skipped

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 19, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.88 KB (+226 B 🔺)
./dist/antd-with-locales.min.js 379.4 KB (-34 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee27f0e) 100.00% compared to head (b53c20b) 100.00%.
Report is 12 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47481   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12596     12657   +61     
  Branches      3300      3323   +23     
=========================================
+ Hits         12596     12657   +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit b96f4c8 into feature Feb 20, 2024
104 of 105 checks passed
@MadCcc MadCcc deleted the feat/css-var-prefixCls branch February 20, 2024 01:47
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* feat: css var prefix follow prefixCls by default

* docs: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants