Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modal mask should block pointer events when opened #47508

Merged
merged 2 commits into from Feb 21, 2024
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Feb 20, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #46129
fix #47499

💡 Background and solution

这段代码是为了修复 #44197 添加的,实测删掉之后不会复现

📝 Changelog

Language Changelog
🇺🇸 English Fix Modal that pointer events will triggered during openning animation.
🇨🇳 Chinese 修复 Modal 在打开期间会触发其他鼠标事件的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 20, 2024

👁 Visual Regression Report for PR #47508 Failed ❌

🎯 Target branch: master (f7877d0)
📖 View Full Report ↗︎

Image name Expected Actual Diff
qr-code-Popover.dark.png master: f7877d098266edce78616b8c68366a5a6e317d8b current: pr-47508 diff
qr-code-Popover.dark.css-var.png master: f7877d098266edce78616b8c68366a5a6e317d8b current: pr-47508 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Feb 20, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.38 KB (-404 B 🔽)
./dist/antd-with-locales.min.js 379.33 KB (-224 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bafd516:

Sandbox Source
antd reproduction template (forked) Issue #46129

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (944d834) 100.00% compared to head (bafd516) 100.00%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12593     12619   +26     
  Branches      3298      3298           
=========================================
+ Hits         12593     12619   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 6033c69 into master Feb 21, 2024
105 of 106 checks passed
@MadCcc MadCcc deleted the fix/modal-mask branch February 21, 2024 01:58
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

[`&:has(${componentCls}${antCls}-zoom-enter), &:has(${componentCls}${antCls}-zoom-appear)`]:
{
pointerEvents: 'none',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不会重新引起 #43860 #44197 的问题吗?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个问题后来用其他方式解决过,可以用 https://codesandbox.io/s/antd-reproduction-template-forked-fh43nt 这个来测一下,我是没有复现的

@PeachScript PeachScript mentioned this pull request Feb 23, 2024
20 tasks
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
…7508)

* fix: modal mask should block pointer events when opened

* chore: code clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants