Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Solve fixed column's shadow display unexpected issue #47518

Merged
merged 2 commits into from Feb 24, 2024

Conversation

kiner-tang
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #47374

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Solve fixed column's shadow display unexpected issue
🇨🇳 Chinese 解决固定列时阴影展示异常问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

👁 Visual Regression Report for PR #47518 Passed ✅

🎯 Target branch: feature (6c824b7)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Preview is ready

Copy link

socket-security bot commented Feb 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@madccc/duplicate-package-checker-webpack-plugin@1.0.0 None +4 1.49 MB madccc
npm/@qixian.cs/github-contributors-list@2.0.1 network Transitive: environment +2 4.84 MB chenshuai2144
npm/@size-limit/file@11.0.2 None +1 35.5 kB ai
npm/@stackblitz/sdk@1.9.0 None 0 180 kB fvsch
npm/@testing-library/dom@9.3.4 environment +3 3.2 MB testing-library-bot
npm/@testing-library/jest-dom@6.4.2 Transitive: environment, filesystem, network, shell +7 7.5 MB testing-library-bot
npm/@testing-library/react@14.2.1 environment +8 13.9 MB testing-library-bot
npm/@testing-library/user-event@14.5.2 Transitive: environment +4 3.63 MB testing-library-bot
npm/@types/ali-oss@6.16.11 None 0 42.2 kB types
npm/@types/fs-extra@11.0.4 None +1 4.04 MB types
npm/@types/gtag.js@0.0.19 None 0 8.85 kB types
npm/@types/http-server@0.12.4 None 0 4.58 kB types
npm/@types/inquirer@9.0.7 None 0 73.6 kB types
npm/@types/isomorphic-fetch@0.0.39 None 0 2.77 kB types
npm/@types/jest-axe@3.5.9 None +1 85.3 kB types
npm/@types/jest-environment-puppeteer@5.0.6 Transitive: unsafe +2 4.01 MB types
npm/@types/jest-image-snapshot@6.4.0 None +3 4.1 MB types
npm/@types/jest@29.5.12 None 0 78.7 kB types
npm/@types/jquery@3.5.29 None 0 1.12 MB types
npm/@types/jsdom@21.1.6 None +1 4.02 MB types
npm/@types/lodash@4.14.202 None 0 862 kB types
npm/@types/minimist@1.2.5 None 0 6.27 kB types
npm/@types/node@20.11.19 None 0 4 MB types
npm/@types/nprogress@0.2.3 None 0 4.83 kB types
npm/@types/pixelmatch@5.2.6 None +1 4.01 MB types
npm/@types/pngjs@6.0.4 None +1 4 MB types
npm/@types/prismjs@1.26.3 None 0 19.2 kB types
npm/@types/progress@2.0.7 None +1 4.01 MB types
npm/@types/react-copy-to-clipboard@5.0.7 None +1 425 kB types
npm/@types/react-dom@18.2.19 None +1 454 kB types
npm/@types/react-highlight-words@0.16.7 None +1 426 kB types
npm/@types/react-resizable@3.0.7 None +1 428 kB types
npm/@types/react@18.2.57 None 0 420 kB types
npm/@types/semver@7.5.7 None 0 23.2 kB types
npm/@types/tar@6.1.11 None +1 4.03 MB types
npm/@types/throttle-debounce@5.0.2 None 0 6.48 kB types
npm/@types/warning@3.0.3 None 0 2.71 kB types
npm/@typescript-eslint/eslint-plugin@7.0.2 Transitive: environment, filesystem +6 5.69 MB bradzacher, jameshenry
npm/@typescript-eslint/parser@7.0.2 Transitive: environment, filesystem +4 3.1 MB jameshenry
npm/ali-oss@6.20.0 filesystem +2 4.37 MB fengmk2
npm/antd-img-crop@4.21.0 Transitive: environment +2 4.87 MB nanxiaobei
npm/antd-style@3.6.1 environment +7 6.16 MB arvinxx
npm/antd-token-previewer@2.0.8 Transitive: environment +9 29.2 MB madccc
npm/chalk@4.1.2 None +1 42.1 kB sindresorhus
npm/cheerio@1.0.0-rc.12 None 0 558 kB feedic
npm/circular-dependency-plugin@5.2.2 Transitive: environment, filesystem, network, unsafe +1 4.83 MB theron
npm/cross-env@7.0.3 environment 0 29.1 kB kentcdodds
npm/cross-fetch@4.0.0 network +1 195 kB lquixada
npm/crypto@1.0.1 None 0 778 B ehsalazar
npm/dekko@0.2.1 filesystem 0 8.91 kB benjycui
npm/dumi-plugin-color-chunk@1.1.0 Transitive: environment, network +22 13.6 MB wxh16144
npm/dumi@2.3.0-beta.7 Transitive: environment, network +19 13.2 MB peachscript
npm/esbuild-loader@4.0.3 Transitive: environment, filesystem, network, unsafe +1 4.86 MB hirokiosame
npm/eslint-config-airbnb@19.0.4 Transitive: environment, filesystem, unsafe +10 6.18 MB ljharb
npm/eslint-config-prettier@9.1.0 Transitive: environment, filesystem +4 3.1 MB lydell
npm/eslint-import-resolver-typescript@3.6.1 Transitive: environment, filesystem, unsafe +7 4.49 MB jounqin
npm/eslint-plugin-compat@4.2.0 filesystem Transitive: environment +6 3.15 MB amilajack
npm/eslint-plugin-import@2.29.1 filesystem, unsafe Transitive: environment +5 4.34 MB ljharb
npm/eslint-plugin-jest@27.9.0 Transitive: environment, filesystem, network, shell +9 11.7 MB aaronabramov, jeysal, jsonp, ...6 more
npm/eslint-plugin-jsx-a11y@6.8.0 Transitive: environment, filesystem +4 3.82 MB ljharb
npm/eslint-plugin-lodash@7.4.0 filesystem Transitive: environment +5 4.81 MB idok
npm/eslint-plugin-markdown@3.0.1 Transitive: environment, filesystem +4 3.11 MB eslintbot
npm/eslint-plugin-react-hooks@4.6.0 environment Transitive: filesystem +4 3.2 MB gnoff
npm/eslint-plugin-react@7.33.2 filesystem Transitive: environment +5 3.98 MB ljharb
npm/eslint-plugin-unicorn@51.0.1 Transitive: environment, filesystem +5 3.75 MB sindresorhus
npm/eslint@8.56.0 environment, filesystem +3 3.08 MB eslintbot
npm/fast-glob@3.3.2 filesystem 0 96.7 kB mrmlnc
npm/fetch-jsonp@1.3.0 None 0 12.4 kB camsong
npm/fs-extra@11.2.0 None +1 59.6 kB ryanzim
npm/gh-pages@6.1.1 filesystem, shell Transitive: environment +3 276 kB tschaub
npm/glob@10.3.10 Transitive: environment +3 906 kB isaacs
npm/html2sketch@1.0.2 network 0 1.87 MB arvinxx
npm/http-server@14.1.1 environment, filesystem, network +3 221 kB thornjad
npm/husky@9.0.11 environment, filesystem, shell 0 3.61 kB typicode
npm/identity-obj-proxy@3.0.0 None 0 8.38 kB keyanzhang
npm/immer@10.0.3 environment 0 620 kB mweststrate
npm/inquirer@9.2.15 None +4 1.55 MB danielchatfield, mischah, ruyadorno, ...1 more
npm/is-ci@3.0.1 None 0 3.81 kB sibiraj-s
npm/isomorphic-fetch@3.0.0 Transitive: network +1 169 kB mattandrews
npm/jest-axe@8.0.0 None +2 63.1 kB nickcolley
npm/jest-canvas-mock@2.5.2 None 0 112 kB atool
npm/jest-environment-jsdom@29.7.0 Transitive: eval, filesystem, network, shell, unsafe +3 7.14 MB simenb
npm/jest-environment-node@29.7.0 unsafe +1 4.01 MB simenb
npm/jest-image-snapshot@6.4.0 environment, filesystem, shell Transitive: network +8 7.9 MB amexopensource
npm/jest-puppeteer@10.0.1 Transitive: environment +1 333 kB neoziro
npm/jest@29.7.0 Transitive: environment, filesystem, network, shell +2 5.7 MB simenb
npm/jquery@3.7.1 None 0 1.25 MB timmywil
npm/jsdom@24.0.0 eval, filesystem, network, shell, unsafe 0 3.11 MB domenic
npm/jsonml-to-react-element@1.1.11 Transitive: eval, filesystem, network, shell, unsafe +2 3.16 MB benjycui
npm/jsonml.js@0.1.0 Transitive: eval, filesystem, network, shell, unsafe +1 3.14 MB benjycui
npm/lint-staged@15.2.2 None +1 164 kB okonet
npm/lunar-typescript@1.7.3 None 0 1.34 MB 6tail
npm/lz-string@1.5.0 None 0 176 kB pieroxy
npm/mockdate@3.0.5 None 0 13.8 kB boblauer
npm/node-fetch@3.3.2 network 0 107 kB node-fetch-bot
npm/node-notifier@10.0.1 environment, filesystem, network, shell +1 5.69 MB mikaelb
npm/nprogress@0.2.0 None 0 31.8 kB rstacruz
npm/open@10.0.3 environment 0 48.5 kB sindresorhus
npm/pixelmatch@5.3.0 None +1 666 kB mourner
npm/pngjs@7.0.0 None 0 650 kB lukeapage
npm/prettier-plugin-jsdoc@1.3.0 Transitive: environment, filesystem, unsafe +1 8.62 MB hosseinmdeveloper
npm/prettier@3.2.5 environment, filesystem, unsafe 0 8.39 MB prettier-bot
npm/progress@2.0.3 None 0 15.5 kB turbopope
npm/puppeteer@22.1.0 environment 0 329 kB google-wombot, mathias
npm/qs@6.11.2 None 0 241 kB ljharb
npm/rc-footer@0.6.8 Transitive: environment +3 4.87 MB afc163
npm/rc-table@7.41.0 Transitive: environment +6 5.63 MB afc163, benjycui, dxq613, ...6 more
npm/rc-tween-one@3.0.6 Transitive: environment +2 4.89 MB jljsj33
npm/rc-virtual-list@3.11.4 environment +5 5.24 MB zombiej
npm/react-copy-to-clipboard@5.1.0 Transitive: environment +2 372 kB nkbt
npm/react-countup@6.5.0 Transitive: environment +1 350 kB mapkeji
npm/react-draggable@4.4.6 Transitive: environment +2 5.06 MB strml
npm/react-fast-marquee@1.6.4 Transitive: environment +2 4.86 MB justin-chu
npm/react-highlight-words@0.20.0 environment +1 1.92 MB sergei-startsev
npm/react-infinite-scroll-component@6.1.0 Transitive: environment +2 576 kB ankeetmaini
npm/react-intersection-observer@9.8.0 Transitive: environment +2 4.96 MB thebuilder
npm/react-resizable@3.0.5 Transitive: environment +3 5.18 MB strml
npm/react-router-dom@6.22.1 Transitive: environment +2 5.7 MB chancestrickland, mjackson, timdorr
npm/react-sticky-box@2.0.5 Transitive: environment +1 334 kB danielberndt
npm/remark-cli@12.0.0 None +1 34.2 kB wooorm
npm/remark-gfm@4.0.0 None 0 21.4 kB wooorm
npm/remark-html@16.0.1 None 0 17 kB wooorm
npm/remark-lint-no-undefined-references@4.2.1 None 0 20.9 kB wooorm
npm/remark-lint@9.1.2 None 0 6.64 kB wooorm
npm/remark-preset-lint-recommended@6.1.3 None +2 38.5 kB wooorm
npm/remark@15.0.1 None 0 15.7 kB wooorm
npm/runes2@1.1.4 environment 0 120 kB bluelovers
npm/sharp@0.33.2 environment +1 509 kB lovell
npm/simple-git@3.22.0 shell 0 887 kB steveukx
npm/size-limit@11.0.2 None 0 32 kB ai
npm/stylelint-config-rational-order@0.1.2 Transitive: environment, filesystem +3 1.75 MB constverum
npm/stylelint-config-standard@36.0.0 Transitive: environment, filesystem +3 1.52 MB ybiquitous
npm/stylelint-prettier@5.0.0 Transitive: environment, filesystem, unsafe +4 9.92 MB bpscott
npm/stylelint@16.2.1 environment Transitive: filesystem +2 1.51 MB ybiquitous
npm/sylvanas@0.6.1 filesystem Transitive: environment, unsafe +5 14.6 MB chenshuai2144
npm/tar-fs@3.0.5 filesystem 0 16.8 kB mafintosh
npm/tar@6.2.0 environment, filesystem +1 180 kB isaacs
npm/terser@5.27.2 environment, eval 0 2.13 MB fabiosantoscode
npm/tsx@4.7.1 None 0 394 kB hirokiosame
npm/typedoc@0.25.8 None +3 33.5 MB typedoc-bot
npm/typescript@5.3.3 None 0 32 MB typescript-bot
npm/vanilla-jsoneditor@0.21.6 None 0 9.27 MB josdejong
npm/vanilla-tilt@1.8.1 None 0 165 kB micku7zu
npm/webpack@5.90.3 environment, filesystem, network, unsafe 0 4.82 MB evilebottnawi

🚮 Removed packages: npm/rc-table@7.40.0

View full report↗︎

Copy link

socket-security bot commented Feb 21, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/puppeteer@22.1.0, npm/sharp@0.33.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

github-actions bot commented Feb 21, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.61 KB (-166 B 🔽)
./dist/antd-with-locales.min.js 379.52 KB (-4 B 🔽)

Copy link

codesandbox-ci bot commented Feb 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@kiner-tang
Copy link
Member Author

image
image
就升级一个版本,怎么报这些呢

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c824b7) 100.00% compared to head (389927b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12617     12617           
  Branches      3307      3307           
=========================================
  Hits         12617     12617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837
Copy link
Contributor

yoyo837 commented Feb 21, 2024

@SocketSecurity ignore npm/@ant-design/tools@18.0.2
@SocketSecurity ignore npm/core-js@3.34.0
@SocketSecurity ignore npm/sharp@0.33.2
@SocketSecurity ignore npm/@biomejs/biome@1.5.3
@SocketSecurity ignore npm/puppeteer@22.1.0

@kiner-tang kiner-tang marked this pull request as ready for review February 21, 2024 07:17
@yoyo837
Copy link
Contributor

yoyo837 commented Feb 21, 2024

rebase

@li-jia-nan li-jia-nan merged commit ded2836 into feature Feb 24, 2024
105 checks passed
@li-jia-nan li-jia-nan deleted the fix-table-fixed-shadow2 branch February 24, 2024 03:03
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants