feat: Drawer support aria in closable #47543
Conversation
|
|
👁 Visual Regression Report for PR #47543 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
|
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #47543 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 734 734
Lines 12617 12933 +316
Branches 3307 3467 +160
==========================================
+ Hits 12617 12933 +316 ☔ View full report in Codecov by Sentry. |
|
@zombieJ 大佬有空瞅瞅不 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@SocketSecurity ignore npm/core-js@2.6.12 |
|
@SocketSecurity ignore npm/fsevents@1.2.13 |
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
| @@ -361,4 +361,20 @@ describe('Drawer', () => { | |||
| expect(container1.outerHTML).toEqual(container2.outerHTML); | |||
| }); | |||
| }); | |||
| it('should support aria-* and closeIcon by closable', async () => { | |||
There was a problem hiding this comment.
* feat: drawer support aria in closable prop * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code * feat: optimize code
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge