New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix : expand all leaf nodes in root level #47567
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #47567 Passed ✅
🎊 Congrats! No visual-regression diff found. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #47567 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 734 734
Lines 12890 12600 -290
Branches 3440 3299 -141
===========================================
- Hits 12890 12598 -292
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
我加的fix不对吗?这个PR不能修复那个问题? |
额,你加的fix在哪,有链接我看看吗 |
请添加测试用例 |
[ci skip] [skip ci]
已添加测试用例 |
* fix table's scrollbar background color in dark mode * docs : fix "fille" with "filled" * expand all leaf nodes in root level * Add type annotation * code style format * [CodeFactor] Apply fixes to commit 116efaf [ci skip] [skip ci] * simplify the code and add the corresponding testing module --------- Co-authored-by: codefactor-io <support@codefactor.io>
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#47552
💡 Background and solution
使用DirectoryTree且multiple = true的时候,当treeData的isLeaf都为true,defaultExpandAll为false,按住shift连续多选会报错
因为initExpandedKeys在这个情况下是undefined,而事实上,对于第一层的叶子节点(root leaf nodes),应该把它们的key加入到initExpandedKeys列表中
📝 Changelog
☑️ Self-Check before Merge