Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add @babel/runtime into dependencies #47587

Merged
merged 1 commit into from Feb 28, 2024
Merged

chore: add @babel/runtime into dependencies #47587

merged 1 commit into from Feb 28, 2024

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Feb 26, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #47569

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English MISC: Fix that could not build with pnpm hoist: false.
🇨🇳 Chinese 杂项:修复不能在 pnpm 配置 hoist: false 下编译的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 26, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 26, 2024

👁 Visual Regression Report for PR #47587 Passed ✅

🎯 Target branch: master (8eff174)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 333.44 KB (+19 B 🔺)
./dist/antd-with-locales.min.js 379.53 KB (+358 B 🔺)

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@ant-design/colors@7.0.2, npm/@ant-design/compatible@5.1.2, npm/@ant-design/cssinjs@1.18.4, npm/@ant-design/happy-work-theme@1.0.0, npm/@ant-design/icons@5.3.0, npm/@ant-design/react-slick@1.0.2, npm/@ant-design/tools@18.0.2, npm/@antv/g6@4.8.24, npm/@babel/eslint-plugin@7.23.5, npm/@biomejs/biome@1.5.3, npm/@codesandbox/sandpack-react@2.13.2, npm/@ctrl/tinycolor@3.6.1, npm/@dnd-kit/core@6.1.0, npm/@dnd-kit/modifiers@7.0.0, npm/@dnd-kit/sortable@8.0.0, npm/@dnd-kit/utilities@3.2.2, npm/@emotion/react@11.11.3, npm/@emotion/server@11.11.0, npm/@ianvs/prettier-plugin-sort-imports@4.1.1, npm/@madccc/duplicate-package-checker-webpack-plugin@1.0.0, npm/@qixian.cs/github-contributors-list@2.0.1, npm/@rc-component/color-picker@1.5.2, npm/@rc-component/mutate-observer@1.1.0, npm/@rc-component/tour@1.12.3, npm/@rc-component/trigger@1.18.3, npm/@size-limit/file@11.0.2, npm/@stackblitz/sdk@1.9.0, npm/@testing-library/dom@9.3.4, npm/@testing-library/jest-dom@6.4.2, npm/@testing-library/react@14.2.1, npm/@testing-library/user-event@14.5.2, npm/@types/ali-oss@6.16.11, npm/@types/fs-extra@11.0.4, npm/@types/gtag.js@0.0.19, npm/@types/http-server@0.12.4, npm/@types/inquirer@9.0.7, npm/@types/isomorphic-fetch@0.0.39, npm/@types/jest-axe@3.5.9, npm/@types/jest-environment-puppeteer@5.0.6, npm/@types/jest-image-snapshot@6.4.0, npm/@types/jest@29.5.12, npm/@types/jquery@3.5.29, npm/@types/jsdom@21.1.6, npm/@types/lodash@4.14.202, npm/@types/node@20.11.20, npm/@types/nprogress@0.2.3, npm/@types/pixelmatch@5.2.6, npm/@types/pngjs@6.0.4, npm/@types/prismjs@1.26.3, npm/@types/progress@2.0.7, npm/@types/react-copy-to-clipboard@5.0.7, npm/@types/react-dom@18.2.19, npm/@types/react-highlight-words@0.16.7, npm/@types/react-resizable@3.0.7, npm/@types/react@18.2.58, npm/@types/semver@7.5.8, npm/@types/tar@6.1.11, npm/@types/throttle-debounce@5.0.2, npm/@types/warning@3.0.3, npm/@typescript-eslint/eslint-plugin@7.0.2, npm/@typescript-eslint/parser@7.0.2, npm/ali-oss@6.20.0, npm/antd-img-crop@4.21.0, npm/antd-style@3.6.1, npm/antd-token-previewer@2.0.8, npm/chalk@4.1.2, npm/cheerio@1.0.0-rc.12, npm/circular-dependency-plugin@5.2.2, npm/classnames@2.5.1, npm/copy-to-clipboard@3.3.3, npm/cross-env@7.0.3, npm/cross-fetch@4.0.0, npm/crypto@1.0.1, npm/dayjs@1.11.10, npm/dekko@0.2.1, npm/dumi-plugin-color-chunk@1.1.0, npm/dumi@2.3.0-beta.7, npm/esbuild-loader@4.0.3, npm/eslint-config-airbnb@19.0.4, npm/eslint-config-prettier@9.1.0, npm/eslint-import-resolver-typescript@3.6.1, npm/eslint-plugin-compat@4.2.0, npm/eslint-plugin-import@2.29.1, npm/eslint-plugin-jest@27.9.0, npm/eslint-plugin-jsx-a11y@6.8.0, npm/eslint-plugin-lodash@7.4.0, npm/eslint-plugin-markdown@3.0.1, npm/eslint-plugin-react-hooks@4.6.0, npm/eslint-plugin-react@7.33.2, npm/eslint-plugin-unicorn@51.0.1, npm/eslint@8.57.0, npm/fast-glob@3.3.2, npm/fetch-jsonp@1.3.0, npm/fs-extra@11.2.0, npm/gh-pages@6.1.1, npm/glob@10.3.10, npm/html2sketch@1.0.2, npm/http-server@14.1.1, npm/husky@9.0.11, npm/identity-obj-proxy@3.0.0, npm/immer@10.0.3, npm/inquirer@9.2.15, npm/is-ci@3.0.1, npm/isomorphic-fetch@3.0.0, npm/jest-axe@8.0.0, npm/jest-canvas-mock@2.5.2, npm/jest-environment-jsdom@29.7.0, npm/jest-environment-node@29.7.0, npm/jest-image-snapshot@6.4.0, npm/jest-puppeteer@10.0.1, npm/jest@29.7.0, npm/jquery@3.7.1, npm/jsdom@24.0.0, npm/jsonml-to-react-element@1.1.11, npm/jsonml.js@0.1.0, npm/lint-staged@15.2.2, npm/lunar-typescript@1.7.3, npm/lz-string@1.5.0, npm/mockdate@3.0.5, npm/node-fetch@3.3.2, npm/node-notifier@10.0.1, npm/nprogress@0.2.0, npm/open@10.0.3, npm/pixelmatch@5.3.0, npm/pngjs@7.0.0, npm/prettier-plugin-jsdoc@1.3.0, npm/prettier@3.2.5, npm/pretty-format@29.7.0, npm/prismjs@1.29.0, npm/puppeteer@22.2.0, npm/qrcode.react@3.1.0, npm/qs@6.11.2, npm/rc-cascader@3.21.2, npm/rc-checkbox@3.1.0, npm/rc-collapse@3.7.2, npm/rc-dialog@9.3.4, npm/rc-drawer@7.0.0, npm/rc-dropdown@4.1.0, npm/rc-field-form@1.41.0, npm/rc-footer@0.6.8, npm/rc-image@7.5.1, npm/rc-input-number@9.0.0, npm/rc-input@1.4.3, npm/rc-mentions@2.10.1, npm/rc-menu@9.12.4, npm/rc-motion@2.9.0, npm/rc-notification@5.3.0, npm/rc-pagination@4.0.4, npm/rc-picker@4.1.4, npm/rc-progress@3.5.1, npm/rc-rate@2.12.0, npm/rc-resize-observer@1.4.0, npm/rc-segmented@2.3.0, npm/rc-select@14.11.0, npm/rc-slider@10.5.0, npm/rc-steps@6.0.1, npm/rc-switch@4.1.0, npm/rc-table@7.39.0, npm/rc-tabs@14.0.0, npm/rc-textarea@1.6.3, npm/rc-tooltip@6.1.3, npm/rc-tree-select@5.17.0, npm/rc-tree@5.8.5, npm/rc-tween-one@3.0.6, npm/rc-upload@4.5.2, npm/rc-util@5.38.2, npm/rc-virtual-list@3.11.4, npm/react-copy-to-clipboard@5.1.0, npm/react-countup@6.5.0, npm/react-dom@18.2.0, npm/react-draggable@4.4.6, npm/react-fast-marquee@1.6.4, npm/react-highlight-words@0.20.0, npm/react-infinite-scroll-component@6.1.0, npm/react-intersection-observer@9.8.1, npm/react-resizable@3.0.5, npm/react-router-dom@6.22.1, npm/react-sticky-box@2.0.5, npm/react@18.2.0, npm/remark-cli@12.0.0, npm/remark-gfm@4.0.0, npm/remark-html@16.0.1, npm/remark-lint-no-undefined-references@4.2.1, npm/remark-lint@9.1.2, npm/remark-preset-lint-recommended@6.1.3, npm/remark@15.0.1, npm/runes2@1.1.4, npm/scroll-into-view-if-needed@3.1.0, npm/sharp@0.33.2, npm/simple-git@3.22.0, npm/size-limit@11.0.2, npm/stylelint-config-rational-order@0.1.2, npm/stylelint-config-standard@36.0.0, npm/stylelint-prettier@5.0.0, npm/stylelint@16.2.1, npm/sylvanas@0.6.1, npm/tar-fs@3.0.5, npm/tar@6.2.0, npm/terser@5.28.1, npm/throttle-debounce@5.0.0, npm/tsx@4.7.1, npm/typedoc@0.25.8, npm/vanilla-jsoneditor@0.21.6, npm/vanilla-tilt@1.8.1, npm/webpack@5.90.3

View full report↗︎

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8eff174) to head (5513a73).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47587   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12593     12593           
  Branches      3298      3298           
=========================================
  Hits         12593     12593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Feb 26, 2024

搞个 pnpm 的用例?

@MadCcc
Copy link
Member Author

MadCcc commented Feb 28, 2024

搞个 pnpm 的用例?

这个在应用仓库搞应该好点,这个 PR 先合了

@MadCcc MadCcc merged commit fd1e08c into master Feb 28, 2024
111 checks passed
@MadCcc MadCcc deleted the chore/fix-pnpm branch February 28, 2024 01:53
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5.12.7 之后的版本都无法在 pnpm hoist:false 下通过 vite 编译
4 participants