Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CP support Input.TextArea allowClear、autoComplete、className、classNames、style、styles #47589

Merged
merged 11 commits into from Feb 28, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Feb 26, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English CP support Input.TextArea allowClear
CP support Input.TextArea autoComplete
CP support Input.TextArea classNamestyle
CP support Input.TextArea classNamesstyles
🇨🇳 Chinese CP 支持 Input.TextArea 组件 allowClear 属性
CP 支持 Input.TextArea 组件 autoComplete 属性
CP 支持 Input.TextArea 组件 classNamestyle 属性
CP 支持 Input.TextArea 组件 classNamesstyles 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 26, 2024

👁 Visual Regression Report for PR #47589 Passed ✅

🎯 Target branch: feature (6c0d3e4)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Feb 26, 2024

Preview is ready

@li-jia-nan li-jia-nan changed the title feat: CP support Input allowClear feat: CP support Input & Input.TextArea.tsx allowClear Feb 26, 2024
@li-jia-nan li-jia-nan changed the title feat: CP support Input & Input.TextArea.tsx allowClear feat: CP support Input & Input.TextArea allowClear Feb 26, 2024
Copy link
Contributor

github-actions bot commented Feb 26, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 333.8 KB (-58 B 🔽)
./dist/antd-with-locales.min.js 379.66 KB (+207 B 🔺)

Copy link

codesandbox-ci bot commented Feb 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6c0d3e4) to head (45b7542).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47589   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12620     12617    -3     
  Branches      3311      3310    -1     
=========================================
- Hits         12620     12617    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan changed the title feat: CP support Input & Input.TextArea allowClear feat: [WIP] CP support Input & Input.TextArea allowClear Feb 26, 2024
@li-jia-nan li-jia-nan changed the title feat: [WIP] CP support Input & Input.TextArea allowClear feat: CP support Input & Input.TextArea allowClear Feb 26, 2024
@li-jia-nan li-jia-nan changed the title feat: CP support Input & Input.TextArea allowClear feat: CP support Input.TextArea allowClear className classNames style styles Feb 26, 2024
@li-jia-nan li-jia-nan changed the title feat: CP support Input.TextArea allowClear className classNames style styles feat: CP support Input.TextArea allowClearclassNameclassNamesstylestyles Feb 26, 2024
@li-jia-nan li-jia-nan changed the title feat: CP support Input.TextArea allowClearclassNameclassNamesstylestyles feat: CP support Input.TextArea autoCompleteallowClearclassNameclassNamesstylestyles Feb 26, 2024
Signed-off-by: lijianan <574980606@qq.com>
Signed-off-by: lijianan <574980606@qq.com>
Signed-off-by: lijianan <574980606@qq.com>
@li-jia-nan li-jia-nan changed the title feat: CP support Input.TextArea autoCompleteallowClearclassNameclassNamesstylestyles feat: CP support Input.TextArea allowClear、autoComplete、className、classNames、style、styles Feb 27, 2024
@MadCcc
Copy link
Member

MadCcc commented Feb 27, 2024

changelog 合起来写就行,不要加 feat: 前缀,最后是要可以直接用作 changelog 的

@MadCcc MadCcc merged commit 271daaf into feature Feb 28, 2024
108 checks passed
@MadCcc MadCcc deleted the input-icon branch February 28, 2024 01:54
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
…ssNames、style、styles (ant-design#47589)

* feat: CP support Input allowClear

* feat: CP support Input allowClear

* fix: fix

* fix: fix

* revert

* revert

* Update Input.tsx

Signed-off-by: lijianan <574980606@qq.com>

* Update getAllowClear.tsx

Signed-off-by: lijianan <574980606@qq.com>

* Update getAllowClear.tsx

Signed-off-by: lijianan <574980606@qq.com>

* test: add test case

---------

Signed-off-by: lijianan <574980606@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants