Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: rm Tag useless style" #47733

Closed
wants to merge 1 commit into from

Conversation

powerfulyang
Copy link

Revert #47504

Signed-off-by: 非凡少年 <i@powerfulyang.com>
Copy link

stackblitz bot commented Mar 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 6, 2024

👁 Visual Regression Report for PR #47733 Failed ❌

🎯 Target branch: master (44b55c6)
📖 View Full Report ↗︎

Image name Expected Actual Diff
table-basic.compact.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff
table-basic.compact.css-var.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff
table-basic.dark.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff
table-basic.dark.css-var.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff
table-basic.default.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff
table-basic.default.css-var.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff
table-jsx.compact.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff
table-jsx.compact.css-var.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff
table-jsx.dark.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff
table-jsx.dark.css-var.png master: 44b55c643576156e062083c33715bf3dfd68a573 current: pr-47733 diff

Check Full Report for details

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 6, 2024

有方案,不revert, 会有patch上来。

Copy link

codesandbox-ci bot commented Mar 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@powerfulyang
Copy link
Author

#47504 (comment)

这个说法不对哦,我现在的场景是接手别人的代码。一个 tag 的情况也是使用了这个 margin。

不知道你们要咋兼容。。。

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (44b55c6) to head (a91a7d4).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47733   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12637     12637           
  Branches      3323      3323           
=========================================
  Hits         12637     12637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 6, 2024

PR 上来后圈你 review 看看。

@MadCcc
Copy link
Member

MadCcc commented Mar 6, 2024

一个 tag 的情况也是使用了这个 margin

这个就是我们想要纠正的场景

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants