Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump trigger to move click to mouseDown #47775

Merged
merged 7 commits into from Mar 8, 2024
Merged

chore: bump trigger to move click to mouseDown #47775

merged 7 commits into from Mar 8, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 8, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Adjust the closing trigger of Tour, Dropdown, Menu, Tabs, Mentions, Picker, Select, TreeSelect, Cascader, Tooltip, and Popover pop-ups from click to mouseDown to uniformly solve some event timing issues related to pop-up interactions.
🇨🇳 Chinese 调整 Tour、Dropdown、Menu、Tabs、Mentions、Picker、Select、TreeSelect、Cascader、Tooltip、Popover 弹层点击外部的关闭时机,从 click 调整至 mouseDown 以统一解决一些与弹窗相关交互中,事件时序问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 8, 2024

👁 Visual Regression Report for PR #47775 Failed ❌

🎯 Target branch: master (630f4d9)
📖 View Full Report ↗︎

Image name Expected Actual Diff
qr-code-Popover.dark.css-var.png master: 630f4d9cfbf84fa7fd44db7292e441da66f7cbbf current: pr-47775 diff

Check Full Report for details

li-jia-nan
li-jia-nan previously approved these changes Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 334.24 KB (-127 B 🔽)
./dist/antd-with-locales.min.js 380.14 KB (+24 B 🔺)

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 8, 2024

Tour 的minor 还有其他变化,log没写

Copy link

socket-security bot commented Mar 8, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@zombieJ
Copy link
Member Author

zombieJ commented Mar 8, 2024

Tour 的minor 还有其他变化,log没写

这个在 feature 里,patch 版本里不透出。trigger 这个太底层只能一次性全部提掉,比较尴尬。

@zombieJ
Copy link
Member Author

zombieJ commented Mar 8, 2024

@SocketSecurity ignore npm/@ant-design/tools@18.0.2
@SocketSecurity ignore npm/sharp@0.33.2
@SocketSecurity ignore npm/@biomejs/biome@1.5.3
@SocketSecurity ignore npm/puppeteer@22.4.0

Copy link

codesandbox-ci bot commented Mar 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

li-jia-nan
li-jia-nan previously approved these changes Mar 8, 2024
kiner-tang
kiner-tang previously approved these changes Mar 8, 2024
@zombieJ zombieJ dismissed stale reviews from kiner-tang and li-jia-nan via 839af5a March 8, 2024 09:48
li-jia-nan
li-jia-nan previously approved these changes Mar 8, 2024
li-jia-nan
li-jia-nan previously approved these changes Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (630f4d9) to head (ea81dbe).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47775   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12702     12644   -58     
  Branches      3362      3326   -36     
=========================================
- Hits         12702     12644   -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 54c5721 into master Mar 8, 2024
105 of 106 checks passed
@zombieJ zombieJ deleted the bump-trigger branch March 8, 2024 13:31
Copy link
Contributor

github-actions bot commented Mar 8, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@vagusX vagusX mentioned this pull request Mar 9, 2024
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* chore: bump trigger

* chore: bump trigger

* chore: bump trigger

* chore: bump trigger

* chore: fix logic

* fix: context tour config

* test: coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants