Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Select): Update docs for Select new API: labelRender #47811

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

xliez
Copy link
Contributor

@xliez xliez commented Mar 11, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

rc-select 组件新增 API:react-component/select#995

💡 Background and solution

rc-select 组件新增 API,同步更新 antd 文档

📝 Changelog

Language Changelog
🇺🇸 English Update docs for Select new API: labelRender
🇨🇳 Chinese 更新 Select 组件新 API: labelRender 的文档

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 11, 2024

👁 Visual Regression Report for PR #47811 Passed ✅

🎯 Target branch: master (878ecef)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Preview is ready

@afc163
Copy link
Member

afc163 commented Mar 11, 2024

labelRender 在 antd 哪个版本新增的?我怎么在更新日志里没找到?

@xliez
Copy link
Contributor Author

xliez commented Mar 11, 2024

labelRender 在 antd 哪个版本新增的?我怎么在更新日志里没找到?

在 rc-select 14.12.0

antd 是 #47664 中升级了 rc-select 版本

Copy link

codesandbox-ci bot commented Mar 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Signed-off-by: xliez <xliez@foxmail.com>
@li-jia-nan
Copy link
Member

PR title 用英文哈

@xliez xliez changed the title docs: 添加 labelRender API 文档 docs(Select): Update docs for Select new API: labelRender Mar 11, 2024
@xliez
Copy link
Contributor Author

xliez commented Mar 11, 2024

PR title 用英文哈

👌

@afc163
Copy link
Member

afc163 commented Mar 11, 2024

需要在 Changelog 补充相关改动。

Copy link
Contributor

Hi @xliez. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@afc163
Copy link
Member

afc163 commented Mar 14, 2024

图片

@afc163
Copy link
Member

afc163 commented Mar 14, 2024

ping @xliez

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (878ecef) to head (9b288d8).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47811   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12652     12652           
  Branches      3328      3328           
=========================================
  Hits         12652     12652           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 1491b0c into ant-design:master Mar 14, 2024
62 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@xliez xliez deleted the docs/label-render branch March 14, 2024 14:42
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
…#47811)

* docs: 添加 labelRender API 文档

Signed-off-by: xliez <xliez@foxmail.com>

* docs: supplement 5.15.0 changelog

* test: update snapshots

---------

Signed-off-by: xliez <xliez@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants