Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DatePicker itemHeight calculation #47874

Merged
merged 3 commits into from Mar 15, 2024
Merged

fix: DatePicker itemHeight calculation #47874

merged 3 commits into from Mar 15, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 14, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #47550

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix DatePicker component height not correct when customize controlHeight.
🇨🇳 Chinese 修复 DatePicker 配置自定义 controlHeight 时,展示高度不正确的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 14, 2024

👁 Visual Regression Report for PR #47874 Failed ❌

🎯 Target branch: master (f9e9b8b)
📖 View Full Report ↗︎

Image name Expected Actual Diff
date-picker-component-token.compact.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff
date-picker-component-token.compact.css-var.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff
date-picker-component-token.dark.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff
date-picker-component-token.dark.css-var.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff
date-picker-component-token.default.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff
date-picker-component-token.default.css-var.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff
date-picker-multiple-debug.compact.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff
date-picker-multiple-debug.compact.css-var.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff
form-col-24-debug.compact.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff
form-col-24-debug.compact.css-var.png master: f9e9b8b8ed920b3e55be9ae48419fba5871a97eb current: pr-47874 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 14, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 334.52 KB (+62 B 🔺)
./dist/antd-with-locales.min.js 380.44 KB (+188 B 🔺)

Copy link

codesandbox-ci bot commented Mar 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bdc382b) to head (f0f12c7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47874   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12645     12656   +11     
  Branches      3326      3326           
=========================================
+ Hits         12645     12656   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 7884eba into master Mar 15, 2024
105 of 106 checks passed
@zombieJ zombieJ deleted the item-height branch March 15, 2024 02:54
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

afc163 pushed a commit that referenced this pull request Mar 16, 2024
* chore: init

* chore: clean up

* chore: clean up
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* chore: init

* chore: clean up

* chore: clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date Picker with mode 'multiple' computes wrong heights
3 participants