Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: legacy onSelect of TimePicker #47878

Merged
merged 2 commits into from Mar 14, 2024
Merged

fix: legacy onSelect of TimePicker #47878

merged 2 commits into from Mar 14, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 14, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #47871

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English TimePicker warning and compatible with onSelect API which is already removed in v4 but not update in en version doc.
🇨🇳 Chinese TimePicker 警告并兼容 onSelect,该 API 在 v4 中已移除但是在英文文档中被遗留。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 14, 2024

👁 Visual Regression Report for PR #47878 Passed ✅

🎯 Target branch: master (f9e9b8b)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 334.55 KB (+91 B 🔺)
./dist/antd-with-locales.min.js 380.35 KB (+94 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f9e9b8b) to head (30fc774).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47878   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12645     12652    +7     
  Branches      3326      3328    +2     
=========================================
+ Hits         12645     12652    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 2323e95 into master Mar 14, 2024
111 checks passed
@afc163 afc163 deleted the fix-onSelect branch March 14, 2024 13:06
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
* chore: update ts

* docs: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onSelect method not working in TimePicker
4 participants