fix: Typography symbol height exceed line should also support ellipsis #47889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
👁 Visual Regression Report for PR #47889 Failed ❌
Check Full Report for details |
|
|
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
MadCcc
approved these changes
Mar 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47889 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 736 736
Lines 12663 12670 +7
Branches 3328 3330 +2
=========================================
+ Hits 12663 12670 +7 ☔ View full report in Codecov by Sentry. |
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
afc163
pushed a commit
that referenced
this pull request
Mar 16, 2024
#47889) * fix: Typography with ellipsis of symbol height * test: update snapshot
tanzhenyun
pushed a commit
to DraculaPrince/mark15
that referenced
this pull request
Mar 29, 2024
ant-design#47889) * fix: Typography with ellipsis of symbol height * test: update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #41861
💡 Background and solution
📝 Changelog
ellipsis.symbolexceed the single line height will make ellipsis rows not correct issue.ellipsis.symbol超出单行高度时，省略行数不正确的问题。☑️ Self-Check before Merge