chore: move @internal tokens into component token #47912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
👁 Visual Regression Report for PR #47912 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
|
size-limit report 📦
|
afc163
commented
Mar 16, 2024
| @@ -72,19 +84,6 @@ export interface ComponentToken { | |||
| confirmBtnsMarginTop: string | number; | |||
There was a problem hiding this comment.
这段逻辑很奇怪，为了 wireframe 的逻辑在这里加了一些额外的 token 定义。
|
boolean 没有办法给 css var 运算，只能全部放进 component token 里，用 js 逻辑算出结果 |
|
@MadCcc 现在这个逻辑太脏了，还污染了 ComponentToken，后续代码很难维护。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#47909 (comment)
💡 Background and solution
下面的 XxxxToken 就是用来放暂时不对外暴露的 token 的，没必要使用 @internal 在 ComponentToken 里。
📝 Changelog
☑️ Self-Check before Merge