Fix #47967 modal rendering issue #48142
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
👁 Visual Regression Report for PR #48142 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Working Demo video attached. Screen.Recording.2024-03-28.at.10.05.30.AM.1.mov |
yoyo837
reviewed
Apr 13, 2024
| @@ -144,6 +144,13 @@ const Modal: React.FC<ModalProps> = (props) => { | |||
| maskTransitionName={getTransitionName(rootPrefixCls, 'fade', props.maskTransitionName)} | |||
| className={classNames(hashId, className, modal?.className)} | |||
| style={{ ...modal?.style, ...style }} | |||
| bodyStyle={{ | |||
There was a problem hiding this comment.
Personally, I think this is not a good solution.
There was a problem hiding this comment.
Thank you for your review @yoyo837. I am just starting to contribute. Can you please suggest me a nice fix so that i can go through and implement my ideas and give a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem and Scenario.
Changes