enhance: ssr ellipsis effect #48205
Merged
enhance: ssr ellipsis effect #48205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
👁 Visual Regression Report for PR #48205 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
|
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48205 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 743 743
Lines 12856 12859 +3
Branches 3364 3365 +1
=========================================
+ Hits 12856 12859 +3 ☔ View full report in Codecov by Sentry. |
afc163
reviewed
Apr 2, 2024
li-jia-nan
approved these changes
Apr 2, 2024
CooperHash
pushed a commit
to CooperHash/ant-design
that referenced
this pull request
Apr 10, 2024
* enhance: ssr ellipsis effect * test: update snapshot * chore: fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #48200
💡 Background and solution
SSR 的时候文本是不缩起的，这导致体感上很怪异。SSR 阶段无论是否需要 js 测量 ellipsis 都先使用 css 做裁剪。等注水后再使用 js 切割:
SSR
Client
📝 Changelog
ellipsislogic to use CSS ellipsis in SSR to enhance user experience.ellipsis使其在 SSR 阶段使用 CSS 省略以优化用户体验。☑️ Self-Check before Merge