Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Steps with process style in compact theme #48251

Merged
merged 9 commits into from Apr 8, 2024
Merged

fix: Steps with process style in compact theme #48251

merged 9 commits into from Apr 8, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 3, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #48244

💡 Background and solution

历史的回旋镖在 antd 支持了动态主题后打了回来。。。

截屏2024-04-03 18 03 53

📝 Changelog

Language Changelog
🇺🇸 English Fix Steps in compact theme not show the correct progress style.
🇨🇳 Chinese 修复 Steps 的进度样式在紧凑模式下不正确的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

👁 Visual Regression Report for PR #48251 Failed ❌

🎯 Target branch: master (502dac1)
📖 View Full Report ↗︎

Image name Expected Actual Diff
steps-label-placement.compact.png master: 502dac12aaddaf407565c8698abd29dd1fc892dc current: pr-48251 diff
steps-label-placement.compact.css-var.png master: 502dac12aaddaf407565c8698abd29dd1fc892dc current: pr-48251 diff
steps-label-placement.dark.png master: 502dac12aaddaf407565c8698abd29dd1fc892dc current: pr-48251 diff
steps-label-placement.dark.css-var.png master: 502dac12aaddaf407565c8698abd29dd1fc892dc current: pr-48251 diff
steps-label-placement.default.png master: 502dac12aaddaf407565c8698abd29dd1fc892dc current: pr-48251 diff
steps-label-placement.default.css-var.png master: 502dac12aaddaf407565c8698abd29dd1fc892dc current: pr-48251 diff
steps-progress-debug.dark.css-var.png master: 502dac12aaddaf407565c8698abd29dd1fc892dc current: pr-48251 diff
steps-progress.compact.png master: 502dac12aaddaf407565c8698abd29dd1fc892dc current: pr-48251 diff
steps-progress.compact.css-var.png master: 502dac12aaddaf407565c8698abd29dd1fc892dc current: pr-48251 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Preview is ready

@zombieJ zombieJ changed the title Fix steps fix: Steps with process style in compact theme Apr 3, 2024
li-jia-nan
li-jia-nan previously approved these changes Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.38 KB (-19 B 🔽)
./dist/antd-with-locales.min.js 383.55 KB (-2 B 🔽)

Copy link

codesandbox-ci bot commented Apr 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@Wxh16144 Wxh16144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

混个 co-authored

components/steps/style/index.ts Outdated Show resolved Hide resolved
Co-authored-by: 红 <wxh1220@gmail.com>
Signed-off-by: afc163 <afc163@gmail.com>
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (502dac1) to head (5787b5c).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48251   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          743       744    +1     
  Lines        12855     12861    +6     
  Branches      3365      3365           
=========================================
+ Hits         12855     12861    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

li-jia-nan
li-jia-nan previously approved these changes Apr 8, 2024
@afc163
Copy link
Member

afc163 commented Apr 8, 2024

留一个 demo 看效果?

@zombieJ
Copy link
Member Author

zombieJ commented Apr 8, 2024

留一个 demo 看效果?

调整在 label-placement 里了。

@zombieJ
Copy link
Member Author

zombieJ commented Apr 8, 2024

样式冲突了,还要解一下。

@zombieJ zombieJ merged commit 8fc4fa0 into master Apr 8, 2024
103 of 104 checks passed
@zombieJ zombieJ deleted the fix-steps branch April 8, 2024 07:53
@li-jia-nan li-jia-nan mentioned this pull request Apr 15, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

umi 开启紧凑模式,Steps组件样式有问题
4 participants