Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Button support autoInsertSpace prop #48348

Merged
merged 17 commits into from Apr 11, 2024
Merged

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Apr 9, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 1. Button component support autoInsertSpace prop
2. CP component supports the button.autoInsertSpace prop
3. deprecated autoInsertSpaceInButton prop of CP component
🇨🇳 Chinese 1. Button 组件支持 autoInsertSpace 属性,用来移除两个汉字之间的空格
2. CP 组件支持 button.autoInsertSpace 属性,用来移除两个汉字之间的空格
3. 废弃 CP 组件的 autoInsertSpaceInButton 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

👁 Visual Regression Report for PR #48348 Failed ❌

🎯 Target branch: feature (4cba8b8)
📖 View Full Report ↗︎

Image name Expected Actual Diff
steps-label-placement.compact.css-var.png feature: 4cba8b85d5a4512c96ea18f05f37bc1772973235 current: pr-48348 diff
steps-label-placement.dark.css-var.png feature: 4cba8b85d5a4512c96ea18f05f37bc1772973235 current: pr-48348 diff
steps-label-placement.default.css-var.png feature: 4cba8b85d5a4512c96ea18f05f37bc1772973235 current: pr-48348 diff
steps-progress-debug.dark.css-var.png feature: 4cba8b85d5a4512c96ea18f05f37bc1772973235 current: pr-48348 diff
steps-progress.compact.css-var.png feature: 4cba8b85d5a4512c96ea18f05f37bc1772973235 current: pr-48348 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 9, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.63 KB (-219 B 🔽)
./dist/antd-with-locales.min.js 383.74 KB (+14 B 🔺)

Copy link

codesandbox-ci bot commented Apr 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@MadCcc
Copy link
Member

MadCcc commented Apr 9, 2024

autoInsertSpaceInButton 太啰嗦了,作为组件 prop 应该叫 autoInsertSpace 好点。
另外可以在 ConfigProvider 的 button 里配置了

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4cba8b8) to head (0e6750a).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #48348   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12883     12888    +5     
  Branches      3376      3379    +3     
=========================================
+ Hits         12883     12888    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan changed the title feat: Button support autoInsertSpaceInButton prop feat: Button support autoInsertSpace prop Apr 9, 2024
@li-jia-nan
Copy link
Member Author

autoInsertSpaceInButton 太啰嗦了,作为组件 prop 应该叫 autoInsertSpace 好点。 另外可以在 ConfigProvider 的 button 里配置了

done

@Wxh16144
Copy link
Member

Wxh16144 commented Apr 9, 2024

另外可以在 ConfigProvider 的 button 里配置了

既然可以在 CP.button 里面设置了,并且觉得 autoInsertSpaceInButton 太啰嗦了,是不是可以搞一个 autoInsertSpaceInButton 弃用警告,建议通过 CP.button 来改修改

@li-jia-nan
Copy link
Member Author

既然可以在 CP.button 里面设置了,并且觉得 autoInsertSpaceInButton 太啰嗦了,是不是可以搞一个 autoInsertSpaceInButton 弃用警告,建议通过 CP.button 来改修改

只是加了一种新的方式,优先级更高,没说要把旧的方式废弃掉吧

@MadCcc
Copy link
Member

MadCcc commented Apr 10, 2024

旧的废弃一下吧,我们统一收口

@li-jia-nan
Copy link
Member Author

旧的废弃一下吧,我们统一收口

done~

li-jia-nan and others added 2 commits April 10, 2024 17:40
Co-authored-by: MadCcc <madccc@foxmail.com>
Signed-off-by: lijianan <574980606@qq.com>
Co-authored-by: MadCcc <madccc@foxmail.com>
Signed-off-by: lijianan <574980606@qq.com>
@li-jia-nan li-jia-nan requested a review from MadCcc April 11, 2024 04:48
Signed-off-by: lijianan <574980606@qq.com>
@li-jia-nan li-jia-nan requested a review from MadCcc April 11, 2024 06:32
@li-jia-nan li-jia-nan merged commit 6a7945d into feature Apr 11, 2024
102 of 103 checks passed
@li-jia-nan li-jia-nan deleted the btn-autoInsertSpaceInButton branch April 11, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants