New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Button support autoInsertSpace prop #48348
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48348 Failed ❌
Check Full Report for details |
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
autoInsertSpaceInButton 太啰嗦了,作为组件 prop 应该叫 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #48348 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 744 744
Lines 12883 12888 +5
Branches 3376 3379 +3
=========================================
+ Hits 12883 12888 +5 ☔ View full report in Codecov by Sentry. |
done |
既然可以在 CP.button 里面设置了,并且觉得 autoInsertSpaceInButton 太啰嗦了,是不是可以搞一个 |
只是加了一种新的方式,优先级更高,没说要把旧的方式废弃掉吧 |
旧的废弃一下吧,我们统一收口 |
done~ |
Co-authored-by: MadCcc <madccc@foxmail.com> Signed-off-by: lijianan <574980606@qq.com>
Co-authored-by: MadCcc <madccc@foxmail.com> Signed-off-by: lijianan <574980606@qq.com>
Signed-off-by: lijianan <574980606@qq.com>
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
autoInsertSpace
prop2. CP component supports the
button.autoInsertSpace
prop3. deprecated
autoInsertSpaceInButton
prop of CP componentautoInsertSpace
属性,用来移除两个汉字之间的空格2. CP 组件支持
button.autoInsertSpace
属性,用来移除两个汉字之间的空格3. 废弃 CP 组件的
autoInsertSpaceInButton
属性☑️ Self-Check before Merge