Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: week selection not have hover style #48355

Merged
merged 1 commit into from Apr 9, 2024
Merged

fix: week selection not have hover style #48355

merged 1 commit into from Apr 9, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 9, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48342

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix DatePicker of multiple with week picker not show the selection on the panel.
🇨🇳 Chinese 修复 DatePicker 对周选择器配置 multiple 多选时,弹出面板不会正确高亮选中项的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

👁 Visual Regression Report for PR #48355 Failed ❌

🎯 Target branch: master (44cd534)
📖 View Full Report ↗︎

Image name Expected Actual Diff
steps-label-placement.compact.css-var.png master: 44cd5342f7138989aeb9f122e087ae7f0a6d7b3f current: pr-48355 diff
steps-label-placement.dark.css-var.png master: 44cd5342f7138989aeb9f122e087ae7f0a6d7b3f current: pr-48355 diff
steps-label-placement.default.css-var.png master: 44cd5342f7138989aeb9f122e087ae7f0a6d7b3f current: pr-48355 diff
steps-progress-debug.dark.css-var.png master: 44cd5342f7138989aeb9f122e087ae7f0a6d7b3f current: pr-48355 diff
steps-progress.compact.css-var.png master: 44cd5342f7138989aeb9f122e087ae7f0a6d7b3f current: pr-48355 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 9, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.41 KB (-57 B 🔽)
./dist/antd-with-locales.min.js 383.43 KB (-69 B 🔽)

Copy link

codesandbox-ci bot commented Apr 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (44cd534) to head (c5991ed).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48355    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          744       744            
  Lines        12861     13111   +250     
  Branches      3365      3483   +118     
==========================================
+ Hits         12861     13111   +250     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 089514b into master Apr 9, 2024
110 of 111 checks passed
@afc163 afc163 deleted the fix-week branch April 9, 2024 13:34
@PeachScript PeachScript mentioned this pull request Apr 13, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants