Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload has empty space #48370

Merged
merged 2 commits into from Apr 10, 2024
Merged

fix: Upload has empty space #48370

merged 2 commits into from Apr 10, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 10, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48365

💡 Background and solution

  • 来源于 fix: Upload can not click in Form.Item #17897 为了以块状区域展示支持点击。当时因为看是 span 所以选择了 inline-block,但是实际上照片墙总是占满区域,因而切换成 block 是安全的。

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload listType with picture-card or picture-circle has additional space on top.
🇨🇳 Chinese 修复 Upload 配置 listTypepicture-cardpicture-circle 时,上方有额外空隙的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 10, 2024

👁 Visual Regression Report for PR #48370 Failed ❌

🎯 Target branch: master (6b3a635)
📖 View Full Report ↗︎

Image name Expected Actual Diff
config-provider-locale.compact.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff
config-provider-locale.compact.css-var.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff
config-provider-locale.dark.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff
config-provider-locale.dark.css-var.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff
config-provider-locale.default.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff
config-provider-locale.default.css-var.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff
steps-label-placement.compact.css-var.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff
steps-label-placement.dark.css-var.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff
steps-label-placement.default.css-var.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff
steps-progress-debug.dark.css-var.png master: 6b3a6350c3fff086b7cdf85a1fbb0f9aa66e673e current: pr-48370 diff

Check Full Report for details

li-jia-nan
li-jia-nan previously approved these changes Apr 10, 2024
Copy link
Contributor

github-actions bot commented Apr 10, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.34 KB (-77 B 🔽)
./dist/antd-with-locales.min.js 383.33 KB (-106 B 🔽)

crazyair
crazyair previously approved these changes Apr 10, 2024
Copy link

codesandbox-ci bot commented Apr 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6b3a635) to head (5db0c20).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48370   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12866     12866           
  Branches      3365      3365           
=========================================
  Hits         12866     12866           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ dismissed stale reviews from crazyair and li-jia-nan via 5db0c20 April 10, 2024 06:07
@zombieJ zombieJ merged commit ce93531 into master Apr 10, 2024
103 of 104 checks passed
@zombieJ zombieJ deleted the fix-upload-cards branch April 10, 2024 06:51
@PeachScript PeachScript mentioned this pull request Apr 13, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload picture-card 顶部出现多余的空间
5 participants