Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add placeholder option for multiple datepicker #48387

Merged
merged 5 commits into from Apr 16, 2024

Conversation

nova1751
Copy link
Contributor

@nova1751 nova1751 commented Apr 10, 2024

🤔 This is a ...

  • New feature
  • Component style update

🔗 Related issue link

resolve #48461

💡 Background and solution

The placeholder option doesn't work for multiple datepicker. I achieved this function in rc-picker component. Please refer to the react-component/picker#768 This PR add some revelant style code for this feature.

📝 Changelog

Language Changelog
🇺🇸 English Fix DatePicker with multiple to support placeholder.
🇨🇳 Chinese 修复 DatePicker 配置 multipleplaceholder 不展示的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 10, 2024

👁 Visual Regression Report for PR #48387 Failed ❌

🎯 Target branch: master (33ae55f)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
date-picker-component-token.compact.png date-picker-component-token.compact.png date-picker-component-token.compact.png date-picker-component-token.compact.png
date-picker-component-token.compact.png date-picker-component-token.compact.png date-picker-component-token.compact.css-var.png date-picker-component-token.compact.css-var.png
date-picker-component-token.dark.png date-picker-component-token.dark.png date-picker-component-token.dark.png date-picker-component-token.dark.png
date-picker-component-token.dark.png date-picker-component-token.dark.png date-picker-component-token.dark.css-var.png date-picker-component-token.dark.css-var.png
date-picker-component-token.default.png date-picker-component-token.default.png date-picker-component-token.default.png date-picker-component-token.default.png
date-picker-component-token.default.png date-picker-component-token.default.png date-picker-component-token.default.css-var.png date-picker-component-token.default.css-var.png
date-picker-multiple-debug.compact.png date-picker-multiple-debug.compact.png date-picker-multiple-debug.compact.png date-picker-multiple-debug.compact.png
date-picker-multiple-debug.compact.png date-picker-multiple-debug.compact.png date-picker-multiple-debug.compact.css-var.png date-picker-multiple-debug.compact.css-var.png
date-picker-multiple-debug.dark.png date-picker-multiple-debug.dark.png date-picker-multiple-debug.dark.png date-picker-multiple-debug.dark.png
date-picker-multiple-debug.dark.png date-picker-multiple-debug.dark.png date-picker-multiple-debug.dark.css-var.png date-picker-multiple-debug.dark.css-var.png

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Preview is ready

Copy link

codesandbox-ci bot commented Apr 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@nova1751
Copy link
Contributor Author

The following video shows the effect after the code change, however I don't know how to complete this PR, becasue the dependency rc-picker is related to another repo. Could anyone provide some advice?

fa81bace-4a7b-4233-b306-7c3f42c16dc7.mp4

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd90120) to head (0cb393b).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48387    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          744       744            
  Lines        13426     12880   -546     
  Branches      3593      3367   -226     
==========================================
- Hits         13426     12880   -546     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nova1751
Copy link
Contributor Author

@zombieJ @afc163 This issue has been existing for a while. Could you take a look if you have time?

@zombieJ zombieJ self-assigned this Apr 16, 2024
@zombieJ
Copy link
Member

zombieJ commented Apr 16, 2024

The following video shows the effect after the code change, however I don't know how to complete this PR, becasue the dependency rc-picker is related to another repo. Could anyone provide some advice?

Let me check for this.

@nova1751
Copy link
Contributor Author

The following video shows the effect after the code change, however I don't know how to complete this PR, becasue the dependency rc-picker is related to another repo. Could anyone provide some advice?

Let me check for this.

Could you check this PR react-component/picker#768 first, please?

@zombieJ
Copy link
Member

zombieJ commented Apr 16, 2024

@nova1751 I've update your PR deps. Let's wait for CI : )

@nova1751
Copy link
Contributor Author

@zombieJ zombieJ merged commit 5716831 into ant-design:master Apr 16, 2024
66 of 67 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@nova1751 nova1751 deleted the feat/date-picker branch April 25, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker placeholder option doesn't work in multiple mode
3 participants