New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add placeholder option for multiple datepicker #48387
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48387 Failed ❌
Check Full Report for details |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
The following video shows the effect after the code change, however I don't know how to complete this PR, becasue the dependency fa81bace-4a7b-4233-b306-7c3f42c16dc7.mp4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48387 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 744 744
Lines 13426 12880 -546
Branches 3593 3367 -226
==========================================
- Hits 13426 12880 -546 ☔ View full report in Codecov by Sentry. |
Let me check for this. |
Could you check this PR react-component/picker#768 first, please? |
@nova1751 I've update your PR deps. Let's wait for CI : ) |
@zombieJ Please check this preview example, seems to be fine! https://preview-48387-ant-design.surge.sh/components/date-picker-cn#components-date-picker-demo-multiple |
🤔 This is a ...
🔗 Related issue link
resolve #48461
💡 Background and solution
The placeholder option doesn't work for multiple datepicker. I achieved this function in
rc-picker
component. Please refer to the react-component/picker#768 This PR add some revelant style code for this feature.📝 Changelog
multiple
to supportplaceholder
.multiple
时placeholder
不展示的问题。☑️ Self-Check before Merge