New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Collapse): arrow selector #48417
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48417 Passed ✅
🎊 Congrats! No visual-regression diff found. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48417 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 744 744
Lines 13426 12875 -551
Branches 3593 3366 -227
==========================================
- Hits 13426 12875 -551 ☔ View full report in Codecov by Sentry. |
切换箭头的转向动画效果没有了。 |
ad9cd0e
to
cb8230d
Compare
@afc163 已修复 |
@afc163 已补充 |
[English Template / 英文模板]
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
之前的 arrow selector 是
> ${componentCls}-item > ${componentCls}-header ${componentCls}-arrow svg
,实际上是假定了图标组件外层是 span,内层才是 svg。而一些第三方的图标(通过构建器 alias 替换)是没有外层的 span 的,直接是 svg,这样 selector 就会失效。此改进
> ${componentCls}-item > ${componentCls}-header ${componentCls}-arrow
在不改变原组件行为的情况下,兼容了自定义图标替换的使用场景。📝 更新日志
☑️ 请求合并前的自查清单