Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Collapse): arrow selector #48417

Merged
merged 5 commits into from Apr 16, 2024
Merged

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Apr 12, 2024

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 工作流程
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

之前的 arrow selector 是 > ${componentCls}-item > ${componentCls}-header ${componentCls}-arrow svg,实际上是假定了图标组件外层是 span,内层才是 svg。而一些第三方的图标(通过构建器 alias 替换)是没有外层的 span 的,直接是 svg,这样 selector 就会失效。

此改进 > ${componentCls}-item > ${componentCls}-header ${componentCls}-arrow 在不改变原组件行为的情况下,兼容了自定义图标替换的使用场景。

📝 更新日志

语言 更新描述
🇺🇸 英文 Collapse: fixed arrow style when using third-party icons
🇨🇳 中文 Collapse: 修复使用第三方图标时的 arrow 样式

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link

stackblitz bot commented Apr 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 12, 2024

👁 Visual Regression Report for PR #48417 Passed ✅

🎯 Target branch: master (cd90120)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

codesandbox-ci bot commented Apr 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd90120) to head (d8fa5b1).

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48417    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          744       744            
  Lines        13426     12875   -551     
  Branches      3593      3366   -227     
==========================================
- Hits         13426     12875   -551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Apr 13, 2024

切换箭头的转向动画效果没有了。

@guoyunhe
Copy link
Contributor Author

@afc163 已修复

@afc163
Copy link
Member

afc163 commented Apr 16, 2024

图片

@guoyunhe
Copy link
Contributor Author

@afc163 已补充

@afc163 afc163 merged commit 33ae55f into ant-design:master Apr 16, 2024
76 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants