Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ColorPicker default clear value should change if set #48450

Merged
merged 3 commits into from Apr 16, 2024

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Apr 15, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48376

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix ColorPicker that clear color will not change when controlled in strict mode.
🇨🇳 Chinese 修复 ColorPicker 在严格模式下受控时清除颜色无法改变的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 15, 2024

👁 Visual Regression Report for PR #48450 Passed ✅

🎯 Target branch: master (cd90120)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 15, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 15, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.42 KB (+5 B 🔺)
./dist/antd-with-locales.min.js 383.66 KB (+119 B 🔺)

@li-jia-nan
Copy link
Member

ChangeLog 已经合了,这个要放在下个版本吧?

Copy link

codesandbox-ci bot commented Apr 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd90120) to head (79d6e0e).

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48450    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          744       744            
  Lines        13426     12880   -546     
  Branches      3593      3367   -226     
==========================================
- Hits         13426     12880   -546     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 0a7e225 into master Apr 16, 2024
104 checks passed
@MadCcc MadCcc deleted the fix/colorpicker-initialvalue branch April 16, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColorPicker被Form.Item包裹,value不生效
3 participants