Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): support defaultOpen #48481

Merged
merged 9 commits into from Apr 17, 2024

Conversation

linhf123
Copy link
Contributor

@linhf123 linhf123 commented Apr 16, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48483

💡 Background and solution

defaultOpen is not available

📝 Changelog

Language Changelog
🇺🇸 English Change the open default to defaultOpen
🇨🇳 Chinese 将 open 默认值改为 defaultOpen

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

👁 Visual Regression Report for PR #48481 Passed ✅

🎯 Target branch: master (30afc97)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Preview is ready

Copy link

codesandbox-ci bot commented Apr 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 16, 2024

你有现成的复现,要不要先开个issue记录一下?

@linhf123
Copy link
Contributor Author

你有现成的复现,要不要先开个issue记录一下?

我开个 issue 关联一下

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4b2a94e) to head (a472156).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48481   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12881     12882    +1     
  Branches      3367      3368    +1     
=========================================
+ Hits         12881     12882    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linhf123
Copy link
Contributor Author

@afc163 大佬帮忙看看,有个 Size Limit 没过,需要处理吗?

@afc163
Copy link
Member

afc163 commented Apr 17, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.5 KB (+101 B 🔺)
./dist/antd-with-locales.min.js 384.13 KB (+138 B 🔺)

@afc163
Copy link
Member

afc163 commented Apr 17, 2024

一行代码怎么会大这么多。

@afc163
Copy link
Member

afc163 commented Apr 17, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.55 KB (-173 B 🔽)
./dist/antd-with-locales.min.js 383.85 KB (-102 B 🔽)

又小了,见鬼。

@crazyair
Copy link
Member

size-limit report 📦

Path Size
./dist/antd.min.js 336.55 KB (-173 B 🔽)
./dist/antd-with-locales.min.js 383.85 KB (-102 B 🔽)
又小了,见鬼。

人为判断吧,这个忽略吧。。。

@afc163 afc163 merged commit a512f81 into ant-design:master Apr 17, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover defaultOpen 失效
7 participants