Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: up rc-field-form #48486

Merged
merged 2 commits into from Apr 17, 2024
Merged

chore: up rc-field-form #48486

merged 2 commits into from Apr 17, 2024

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Apr 16, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese async-validator 替换为 @rc-component/async-validator,并修复 transform 没有自动检测返回值类型的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

👁 Visual Regression Report for PR #48486 Passed ✅

🎯 Target branch: feature (8026366)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Preview is ready

@crazyair crazyair changed the base branch from master to feature April 16, 2024 08:39
Copy link

codesandbox-ci bot commented Apr 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

socket-security bot commented Apr 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-field-form@2.0.0 environment 0 279 kB afc163

🚮 Removed packages: npm/pngjs@7.0.0, npm/rc-field-form@1.44.0

View full report↗︎

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 16, 2024

这个到时候发布日志里得重点标注,因为有一些人可能外部依赖了这个上游,antd修改后会冗余一个库。

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8026366) to head (9f45013).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #48486   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12896     12896           
  Branches      3382      3382           
=========================================
  Hits         12896     12896           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lemonied
Copy link
Contributor

pro-components里的依赖是不是也得改一下?

{
  "peerDependencies": {
    "rc-field-form": "^1.22.0",
  }
}

现在的是^1.22.0

@crazyair crazyair requested a review from afc163 April 16, 2024 10:10
@afc163
Copy link
Member

afc163 commented Apr 16, 2024

pro-components 为啥会依赖 rc-field-form。。。

@lemonied
Copy link
Contributor

@crazyair
Copy link
Member Author

crazyair commented Apr 17, 2024

不清楚一开始为什么 table 加依赖了 https://github.com/ant-design/pro-components/pull/4162/files @chenshuai2144

@vagusX vagusX closed this Apr 17, 2024
@vagusX vagusX reopened this Apr 17, 2024
@vagusX
Copy link
Member

vagusX commented Apr 17, 2024

reopen to trigger visual-regression because the target branch is changed

@crazyair
Copy link
Member Author

reopen to trigger visual-regression because the target branch is changed

哈哈哈,这确实是个问题,我都是先创建,然后再改,workflow 能检测 target branch 再重新跑就好了

@vagusX
Copy link
Member

vagusX commented Apr 17, 2024

reopen to trigger visual-regression because the target branch is changed

哈哈哈,这确实是个问题,我都是先创建,然后再改,workflow 能检测 target branch 再重新跑就好了

应该不行,有一个 pr edit 事件,但是改 pr 任意信息都会触发,比如改 pr 标题和描述

@afc163 afc163 closed this Apr 17, 2024
@afc163 afc163 reopened this Apr 17, 2024
@afc163
Copy link
Member

afc163 commented Apr 17, 2024

为啥会大怎么多?

@crazyair
Copy link
Member Author

为啥会大怎么多?

编译的方式变了吗?产物有没有区别

@crazyair
Copy link
Member Author

async-validator-4.2.5.tgz(65.6 KB)
@rc-component/async-validator-5.0.1.tgz(22 KB)

https://npmmirror.com/package/@rc-component/async-validator/files?version=5.0.1
https://npmmirror.com/package/async-validator/files?version=4.2.5

@ant-design ant-design deleted a comment from github-actions bot Apr 17, 2024
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 336.74 KB (-61 B 🔽)
./dist/antd-with-locales.min.js 383.88 KB (+23 B 🔺)

@crazyair
Copy link
Member Author

size-limit report 📦

Path Size
./dist/antd.min.js 336.74 KB (-61 B 🔽)
./dist/antd-with-locales.min.js 383.88 KB (+23 B 🔺)

@afc163 看看

@afc163 afc163 changed the title up rc-field-form chore: up rc-field-form Apr 17, 2024
@afc163 afc163 merged commit 9b72caf into feature Apr 17, 2024
106 checks passed
@afc163 afc163 deleted the up-form-2 branch April 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants