Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed disabled text display exception for TextArea #48489

Merged
merged 1 commit into from Apr 18, 2024

Conversation

korkt-kim
Copy link
Contributor

@korkt-kim korkt-kim commented Apr 16, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48484

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fixed disabled text display exception for TextArea
🇨🇳 Chinese 修复禁用的 TextArea 的文字显示异常问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 16, 2024

👁 Visual Regression Report for PR #48489 Passed ✅

🎯 Target branch: master (c8f6aee)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

codesandbox-ci bot commented Apr 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@afc163
Copy link
Member

afc163 commented Apr 16, 2024

Input disabled cursor style should be handled too.

@korkt-kim
Copy link
Contributor Author

korkt-kim commented Apr 16, 2024

Input disabled cursor style should be handled too.

I've added cursor: not-allowed on textarea[disabled] just like input component

@kiner-tang kiner-tang changed the title fix: Change text color in disabled textarea fix: Fixed disabled text display exception for TextArea Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (273104c) to head (e9b8f37).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48489    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          744       744            
  Lines        13498     12883   -615     
  Branches      3612      3369   -243     
==========================================
- Hits         13498     12883   -615     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Apr 17, 2024

Please check https://antd-visual-diff.oss-cn-shanghai.aliyuncs.com/pr-48489/visualRegressionReport/report.html

@korkt-kim korkt-kim force-pushed the fix-textarea-disabled-color branch 2 times, most recently from d5affa1 to d7dab01 Compare April 17, 2024 15:13
@afc163 afc163 merged commit 1b43d38 into ant-design:master Apr 18, 2024
61 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@korkt-kim korkt-kim deleted the fix-textarea-disabled-color branch April 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input.TextArea disabled 时候字体没有变,鼠标放上也没有变化
2 participants