Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: noStyle no warning #48508

Merged
merged 1 commit into from Apr 17, 2024
Merged

feat: noStyle no warning #48508

merged 1 commit into from Apr 17, 2024

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Apr 17, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Remove the warning from noStyle that does not pass on to children
🇨🇳 Chinese noStyle 去掉不传 children 的 warning

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 17, 2024

👁 Visual Regression Report for PR #48508 Passed ✅

🎯 Target branch: master (a512f81)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Preview is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 336.55 KB
./dist/antd-with-locales.min.js 383.85 KB

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a512f81) to head (47b8952).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12882     12883    +1     
  Branches      3368      3369    +1     
=========================================
+ Hits         12882     12883    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 0d34e0b into master Apr 17, 2024
113 of 114 checks passed
@zombieJ zombieJ deleted the no-style-no-wraning branch April 17, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants