Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch checkedChildren no height #48513

Merged
merged 3 commits into from Apr 17, 2024
Merged

Conversation

wanpan11
Copy link
Contributor

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48503

💡 Background and solution

switch 组件 checkedChildren unCheckedChildren 没有默认高度
checkedChildren 为空时会造成 unCheckedChildren 定位错误

📝 Changelog

Language Changelog
🇺🇸 English switch component props checkedChildren unCheckedChildren add min-height
🇨🇳 Chinese switch 组件 checkedChildren unCheckedChildren 添加 min-height

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 17, 2024

👁 Visual Regression Report for PR #48513 Passed ✅

🎯 Target branch: master (d524a4c)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

codesandbox-ci bot commented Apr 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d524a4c) to head (ba4ac3f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48513   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12883     12883           
  Branches      3369      3369           
=========================================
  Hits         12883     12883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ self-assigned this Apr 17, 2024
@zombieJ zombieJ merged commit 273104c into ant-design:master Apr 17, 2024
60 of 61 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@wanpan11 wanpan11 deleted the fix-switch branch April 17, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch doesn't show icon if there is only unCheckedChildren
3 participants