New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tabindex option for paragraph button #48567
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48567 Passed ✅
🎊 Congrats! No visual-regression diff found. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #48567 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 12979 12982 +3
Branches 3403 3404 +1
=========================================
+ Hits 12979 12982 +3 ☔ View full report in Codecov by Sentry. |
0e3dbd1
to
5efdce5
Compare
看下覆盖率。 |
我不是很懂为何会报错,是需要为 |
看上去是的。 |
给 |
新功能需要提交到 feature 分支,另外 api 文档里面要补一下版本号 |
版本号的话使用当前版本号的下一个版本号比较好吗 |
嗯,写 5.17.0 |
另外分支需要清理一下,你把 master 分支的提交带过来了,PR 里面不应该出现不相关的 commit |
OK, 我 |
c0c2cca
to
c240ea8
Compare
奇怪,为什么codecov又出问题了 |
还是不懂为何覆盖率继续报错了,能提供些建议吗?@afc163 @li-jia-nan |
要覆盖这个,应该需要没有传入locale,让他走默认值的情况 |
新增一个走默认值的即可。 |
抱歉我刚刚的表述有点问题,我的意思是我新添加了一个走默认值的测试用例,就是上面那张截图,当初向master分支合的时候覆盖率通过了,但不知道为啥向feature分支合的时候又报了这个错误,接下来我就不懂该怎么操作了,由于这个 |
再新增一个非默认值的用例试试? |
可以先在本地生成测试覆盖率报告看一下: |
Signed-off-by: lijianan <574980606@qq.com>
Signed-off-by: lijianan <574980606@qq.com>
Signed-off-by: lijianan <574980606@qq.com>
Signed-off-by: lijianan <574980606@qq.com>
Signed-off-by: lijianan <574980606@qq.com>
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
The
Paragraph
component didn't support the tabIndex option for edit and copy button. I achieved this feature.📝 Changelog
Paragraph
componentParagraph
组件的按钮添加tabIndex
选项☑️ Self-Check before Merge