Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: margin problem in css value mode #48569

Merged
merged 4 commits into from Apr 22, 2024
Merged

Conversation

nova1751
Copy link
Contributor

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#48505

💡 Background and solution

Related to PR #48522. The previous change didn't adpat to the css value mode in runtime. So such change is more reasonable😂
Previous
image
After change
image

📝 Changelog

Language Changelog
🇺🇸 English fix the animation effect of upload component in css-value mode
🇨🇳 Chinese 修复 upload 组件在 css 值模式动画效果的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 21, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 21, 2024

👁 Visual Regression Report for PR #48569 Passed ✅

🎯 Target branch: master (c321492)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

codesandbox-ci bot commented Apr 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@nova1751 nova1751 changed the title fix: adapt margin problem in css value mode fix: margin problem in css value mode Apr 21, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c321492) to head (b98bc76).

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48569    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          745       745            
  Lines        13593     12937   -656     
  Branches      3627      3382   -245     
==========================================
- Hits         13593     12937   -656     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit c3f5e27 into ant-design:master Apr 22, 2024
61 checks passed
@zombieJ zombieJ mentioned this pull request Apr 22, 2024
16 tasks
@nova1751 nova1751 deleted the fix/upload branch April 25, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants