Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select token with paddingXXS #48574

Merged
merged 5 commits into from Apr 22, 2024
Merged

fix: Select token with paddingXXS #48574

merged 5 commits into from Apr 22, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 22, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48043

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select with multiple and paddingXXS=0 will break the height align of controlHeight token.
🇨🇳 Chinese 修复 Select 配置 paddingXXS=0 时,多选下超出设定的 controlHeight token 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

👁 Visual Regression Report for PR #48574 Failed ❌

🎯 Target branch: master (ff2268e)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
select-component-token.compact.png select-component-token.compact.png select-component-token.compact.png select-component-token.compact.png
select-component-token.compact.png select-component-token.compact.png select-component-token.compact.css-var.png select-component-token.compact.css-var.png
select-component-token.dark.png select-component-token.dark.png select-component-token.dark.png select-component-token.dark.png
select-component-token.dark.png select-component-token.dark.png select-component-token.dark.css-var.png select-component-token.dark.css-var.png
select-component-token.default.png select-component-token.default.png select-component-token.default.png select-component-token.default.png
select-component-token.default.png select-component-token.default.png select-component-token.default.css-var.png select-component-token.default.css-var.png

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 22, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 337.11 KB (+69 B 🔺)
./dist/antd-with-locales.min.js 384.54 KB (-86 B 🔽)

Copy link

codesandbox-ci bot commented Apr 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c321492) to head (fd8b864).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #48574    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          745       745            
  Lines        13593     13072   -521     
  Branches      3627      3443   -184     
==========================================
- Hits         13593     13072   -521     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 4eebc0c into master Apr 22, 2024
103 of 104 checks passed
@zombieJ zombieJ deleted the fix-token branch April 22, 2024 05:50
@zombieJ zombieJ mentioned this pull request Apr 22, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select 组件 单选多选从controlHeight获取高度不统一
2 participants