-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing translation for id and jp #48690
Conversation
Run & review this pull request in StackBlitz Codeflow. |
So, is this overturning the previous PR #48287 ? |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Yes, because many user say it's better like the original, namely 'OK'. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48690 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 12947 12947
Branches 3383 3383
=========================================
Hits 12947 12947 ☔ View full report in Codecov by Sentry. |
Personally, it is better to split it into two PRs. |
What do you mean, Indonesian and Japanese PR are separated? |
Yes. |
0609f68
to
3b4809d
Compare
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge