New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Button icon order and margin in rtl mode #48821
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48821 Failed ❌
Check Full Report for details |
size-limit report 📦
|
components/button/__tests__/__snapshots__/demo-extend.test.ts.snap
Outdated
Show resolved
Hide resolved
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
components/button/__tests__/__snapshots__/demo-extend.test.ts.snap
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48821 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 746 746
Lines 12996 12994 -2
Branches 3412 3411 -1
=========================================
- Hits 12996 12994 -2 ☔ View full report in Codecov by Sentry. |
68227f8 这个要不要看一下,感觉可以 revert。 原因我在我的那个 pr 里面描述了一嘴 |
@Wxh16144 对,感觉也可以回滚。 |
想合并了 #47318 后用 |
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
fix #48807
close #48813
close #48811
💡 Background and solution
RTL 本身会改变文本顺序,不需要增加额外判断。https://github.com/ant-design/ant-design/pull/47791/files#r1593303396
📝 Changelog
☑️ Self-Check before Merge