Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicated items when children count is 1 #113

Merged
merged 1 commit into from
Apr 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion __tests__/regression/fix-1813.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
getButtons,
getButtonsLength,
getClonesCount,
getCurrentSlide,
getSlidesCount
} from "../../test-utils";
import { GenericSliderComponent } from "../TestComponents";
Expand All @@ -28,13 +27,29 @@ function MultipleItems() {
return <GenericSliderComponent slidesCount={9} settings={settings} />;
}

function SingleItem() {
const settings = {
dots: true,
infinite: true,
speed: 500,
slidesToShow: 1
};
return <GenericSliderComponent slidesCount={1} settings={settings} />;
}

describe("Multiple Items with slidesToShow = slides count in infinite mode", function () {
it("should have 9 actual slides and (9(pre) + 9(post)) clone slides", function () {
//Todo: Need to fix extra clones
const { container } = render(<MultipleItems />);
expect(getSlidesCount(container)).toEqual(27);
expect(getClonesCount(container)).toEqual(18);
});
// https://github.com/akiran/react-slick/issues/2359
it("should not have cloned slide", function () {
const { container } = render(<SingleItem />);
expect(getSlidesCount(container)).toEqual(1);
expect(getClonesCount(container)).toEqual(0);
});
it("should have 9 active slides", function () {
const { container } = render(<MultipleItems />);
expect(getActiveSlidesCount(container)).toEqual(9);
Expand Down
7 changes: 6 additions & 1 deletion src/track.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,12 @@ const renderSlides = (spec) => {
);

// if slide needs to be precloned or postcloned
if (spec.infinite && spec.fade === false && !spec.unslick) {
if (
spec.infinite &&
childrenCount > 1 &&
spec.fade === false &&
!spec.unslick
) {
let preCloneNo = childrenCount - index;
if (preCloneNo <= getPreClones(spec)) {
key = -preCloneNo;
Expand Down