GH Actions: ensure zend assertions is enabled #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the change made in commit antecedent@2657911 , `zend.assertions` is set to `-1` by default, so needs to be turned on by setting it to `1` for the tests to work. Ref: shivammathur/setup-php#450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the change made in commit 2657911 ,
zend.assertionsis set to-1by default, so needs to be turned on by setting it to1for the tests to work.This fixes the two errors previously identified in #112,
but exposes another test which really does fail and that failure can be reproduced locally.Update: looks like that failure has been fixed in the mean time.Ref: shivammathur/setup-php#450
Fixes #112