feat(ts): ban const enum

antfu · Jun 15, 2023 · b96f78a · b96f78a
1 parent bbed70b
commit b96f78a
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 1 deletion.
diff --git a/packages/eslint-config-ts/index.js b/packages/eslint-config-ts/index.js
@@ -10,6 +10,7 @@ module.exports = {
     'plugin:import/typescript',
     'plugin:@typescript-eslint/recommended',
   ],
+  plugins: ['@rnx-kit'],
   settings: {
     'import/resolver': {
       node: { extensions: ['.js', '.jsx', '.mjs', '.ts', '.tsx', '.d.ts'] },
@@ -160,6 +161,9 @@ module.exports = {
     'antfu/no-cjs-exports': 'error',
     'antfu/no-ts-export-equal': 'error',
 
+    // best practices
+    '@rnx-kit/no-const-enum': 'error',
+
     // off
     '@typescript-eslint/consistent-indexed-object-style': 'off',
     '@typescript-eslint/naming-convention': 'off',

diff --git a/packages/eslint-config-ts/package.json b/packages/eslint-config-ts/package.json
@@ -18,6 +18,7 @@
   },
   "dependencies": {
     "@antfu/eslint-config-basic": "workspace:*",
+    "@rnx-kit/eslint-plugin": "^0.4.2",
     "@typescript-eslint/eslint-plugin": "^5.59.7",
     "@typescript-eslint/parser": "^5.59.7",
     "eslint-plugin-jest": "^27.2.1"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml