Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support solid.js #441

Merged
merged 3 commits into from
Apr 8, 2024
Merged

feat: support solid.js #441

merged 3 commits into from
Apr 8, 2024

Conversation

subframe7536
Copy link
Contributor

Description

Add a eslint config for solid.js with eslint-plugin-solid.

Linked Issues

Not yet.

Additional context

No special rules, just add solid eslint plugin.

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for melodious-froyo-4871f8 ready!

Name Link
🔨 Latest commit 6cba0bd
🔍 Latest deploy log https://app.netlify.com/sites/melodious-froyo-4871f8/deploys/6613fab70edde7000837bc02
😎 Deploy Preview https://deploy-preview-441--melodious-froyo-4871f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@squirmy
Copy link
Contributor

squirmy commented Apr 8, 2024

This PR came at an opportune time for me. Was just playing around with Solid and was wondering why my jsx files weren't linting.

For some reason, the base configuration skips linting the jsx / tsx files if react is not being used. I'm not sure if that's intentional or not.

But including the configuration in this PR and adding the solid eslint plugin works well. 👍

@antfu antfu changed the title feat: add eslint config for solid.js feat: support solid.js Apr 8, 2024
@antfu antfu merged commit 6406114 into antfu:main Apr 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants