-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Vue version auto detection #444
Conversation
✅ Deploy Preview for melodious-froyo-4871f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you but no. We did that on purpose, as Vue 2 has already reached EOL, and there is no reason for me to actively support it anymore. Auto-detection would be the overhead that I don't think is worth taking either. |
OK. But the document improvement is not acceptable either? The configuration |
That's why it's important to have each PR atomic - so they can be discussed and merged separately. I can't take this PR as-is. |
I see. The another PR: #445 contains three changes:
I understand that 1 should be removed. 2 is acceptable. So would you accept 3? I can submit a new PR. |
I don't think 3 is necessary; breaking changes should always be avoided if possible. And I named it |
OK. I've submitted a new PR for 2. |
Description
After debugging, I found that #443 is not a bug but rather missing documentation. I will submit two PRs (for two different solutions) to address this issue: one for automatic detection of the Vue version (this one), and another for documentation improvement: #445. Additionally, I've changed
vue.vueVersion
tovue.version
for a more streamlined configuration. (It's a breaking change). You can choose the solution you think is appropriate to merge, thanks.Linked Issues
#443
Additional context