Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Vue version auto detection #444

Closed
wants to merge 2 commits into from
Closed

Conversation

cloydlau
Copy link
Contributor

@cloydlau cloydlau commented Apr 12, 2024

Description

After debugging, I found that #443 is not a bug but rather missing documentation. I will submit two PRs (for two different solutions) to address this issue: one for automatic detection of the Vue version (this one), and another for documentation improvement: #445. Additionally, I've changed vue.vueVersion to vue.version for a more streamlined configuration. (It's a breaking change). You can choose the solution you think is appropriate to merge, thanks.

Linked Issues

#443

Additional context

Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for melodious-froyo-4871f8 ready!

Name Link
🔨 Latest commit 3fde4f8
🔍 Latest deploy log https://app.netlify.com/sites/melodious-froyo-4871f8/deploys/66188bbf53468900081fdc95
😎 Deploy Preview https://deploy-preview-444--melodious-froyo-4871f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu
Copy link
Owner

antfu commented Apr 12, 2024

Thank you but no. We did that on purpose, as Vue 2 has already reached EOL, and there is no reason for me to actively support it anymore. Auto-detection would be the overhead that I don't think is worth taking either.

@antfu antfu closed this Apr 12, 2024
@cloydlau
Copy link
Contributor Author

cloydlau commented Apr 12, 2024

OK. But the document improvement is not acceptable either? The configuration vue.vueVersion does exists, but the user has no way to know that.

@antfu
Copy link
Owner

antfu commented Apr 12, 2024

That's why it's important to have each PR atomic - so they can be discussed and merged separately. I can't take this PR as-is.

@cloydlau
Copy link
Contributor Author

cloydlau commented Apr 12, 2024

I see. The another PR: #445 contains three changes:

  1. Feature description
  2. Explain how to configure the Vue version
  3. Rename vue.vueVersion to vue.version

I understand that 1 should be removed. 2 is acceptable. So would you accept 3? I can submit a new PR.

@antfu
Copy link
Owner

antfu commented Apr 12, 2024

I don't think 3 is necessary; breaking changes should always be avoided if possible. And I named it vueVersion to be specific that it's about Vue (not vue-router, volar or the version of package itself).

@cloydlau
Copy link
Contributor Author

OK. I've submitted a new PR for 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants