refactor!: migrate from eslint-plugin-react to eslint react #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for melodious-froyo-4871f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
Apr 17, 2024
| 'react/no-useless-fragment': 'warn', | ||
| 'react/prefer-destructuring-assignment': 'warn', | ||
| 'react/prefer-shorthand-boolean': 'warn', | ||
| 'react/prefer-shorthand-fragment': 'warn', |
There was a problem hiding this comment.
So, actually, they are completely separate implementations with unrelated sets of rules? I thought it was a fork
There was a problem hiding this comment.
It's not just a fork, you can understand their differences from the links provided in the issue. https://eslint-react.xyz/docs/faq
It does implement some rules in eslint-plugin-react. Rel1cx/eslint-react#85.
For me, its advantages are：
- It's a modern rewrite with TypeScript
- It can lint with type information
- It removes all Stylistic rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
close #452
Additional context
Sorry for direct ping, maybe @Rel1cx @SukkaW would like to look at this.