fix(react): improve option for react-refresh #455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for melodious-froyo-4871f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
Apr 19, 2024
Comment on lines
+104
to
+122
| allowExportNames: isUsingNext | ||
| ? [ | ||
| 'config', | ||
| 'generateStaticParams', | ||
| 'metadata', | ||
| 'generateMetadata', | ||
| 'viewport', | ||
| 'generateViewport', | ||
| ] | ||
| : isUsingRemix | ||
| ? [ | ||
| 'meta', | ||
| 'links', | ||
| 'headers', | ||
| 'loader', | ||
| 'action', | ||
| ] | ||
| : undefined, | ||
| }, |
There was a problem hiding this comment.
I would allow all of them directly without checking the packages - would that have any bad side-effects?
There was a problem hiding this comment.
I don't think it should be a big problem, but when using pure vite and react, if the exported name coincides with the preset, it will still affect fast refresh.
antfu
changed the title
|
I couldn't push to your branch - did you unchecked the "allow edit from maintainer" box? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
Additional context